[processor/resourcedetection]: add additional os properties #40257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
processor/resourcedetection
minimAluminiumalism
force-pushed
the
main
branch
2 times, most recently
from
802e263 to
71040c0
Compare
atoulme
changed the title
atoulme
reviewed
May 28, 2025
.chloggen/add_additional_os_ properties_to_resource_detection.yaml
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
May 29, 2025
atoulme
approved these changes
Jun 2, 2025
atoulme
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add properties which are missing in https://github.com/open-telemetry/semantic-conventions/blob/45e91aedff7d347955ba09269b871f8fd9049ce3/docs/resource/os.md, and the logic for getting
os.nameandos.build.idis also comes from here.Link to tracking issue
Implementation #39941
Testing
TestDetectOSNameAndBuildIDinprocessor/resourcedetectionprocessor/internal/system/system_test.goDocumentation