-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add additional os.* properties to resource detection #39941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
Yep the resources outlined there are the ones I'm referring to as not being populated today |
It makes sense to me, supporting this additional information, since they are already part of the semconv |
@odubajDT Hey, I’d like to work on this issue. Could you please assign it to me? |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add properties which are missing in https://github.com/open-telemetry/semantic-conventions/blob/45e91aedff7d347955ba09269b871f8fd9049ce3/docs/resource/os.md, and the logic for getting `os.name` and `os.build.id` is also comes from here. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Implementation #39941 <!--Describe what testing was performed and which tests were added.--> #### Testing `TestDetectOSNameAndBuildID` in `processor/resourcedetectionprocessor/internal/system/system_test.go` <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
closed by #40257 |
Uh oh!
There was an error while loading. Please reload this page.
Component(s)
No response
Is your feature request related to a problem? Please describe.
Currently, the resource detection processor populates:
It would be nice if it populated the other os.* semconv attributes, namely
os.build.id
,os.name
Describe the solution you'd like
the resource detection processor to populate os.name and os.build.id
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: