Skip to content

Add additional os.* properties to resource detection #39941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strawgate opened this issue May 8, 2025 · 6 comments
Closed

Add additional os.* properties to resource detection #39941

strawgate opened this issue May 8, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers processor/resourcedetection Resource detection processor

Comments

@strawgate
Copy link
Contributor

strawgate commented May 8, 2025

Component(s)

No response

Is your feature request related to a problem? Please describe.

Currently, the resource detection processor populates:

attribute description
os.description Human readable OS version information.
os.type The os.type
os.version The os.version

It would be nice if it populated the other os.* semconv attributes, namely os.build.id, os.name

Describe the solution you'd like

the resource detection processor to populate os.name and os.build.id

Describe alternatives you've considered

No response

Additional context

No response

@strawgate strawgate added enhancement New feature or request needs triage New item requiring triage labels May 8, 2025
@iblancasa iblancasa added the processor/resourcedetection Resource detection processor label May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@iblancasa
Copy link
Contributor

@strawgate
Copy link
Contributor Author

https://github.com/open-telemetry/semantic-conventions/blob/45e91aedff7d347955ba09269b871f8fd9049ce3/docs/resource/os.md

Yep the resources outlined there are the ones I'm referring to as not being populated today

@odubajDT
Copy link
Contributor

odubajDT commented May 9, 2025

It makes sense to me, supporting this additional information, since they are already part of the semconv

@odubajDT odubajDT added good first issue Good for newcomers and removed needs triage New item requiring triage labels May 9, 2025
@minimAluminiumalism
Copy link
Contributor

@odubajDT Hey, I’d like to work on this issue. Could you please assign it to me?

songy23 pushed a commit that referenced this issue Jun 3, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Add properties which are missing in
https://github.com/open-telemetry/semantic-conventions/blob/45e91aedff7d347955ba09269b871f8fd9049ce3/docs/resource/os.md,
and the logic for getting `os.name` and `os.build.id` is also comes from
here.


<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Implementation
#39941

<!--Describe what testing was performed and which tests were added.-->
#### Testing

`TestDetectOSNameAndBuildID` in
`processor/resourcedetectionprocessor/internal/system/system_test.go`

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
@JaredTan95
Copy link
Member

closed by #40257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers processor/resourcedetection Resource detection processor
Projects
None yet
Development

No branches or pull requests

5 participants