signaltometricsconnector: support gauges #40113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for gauges with last value aggregation. relates to open-telemetry#37093
lahsivjar
reviewed
May 16, 2025
lahsivjar
reviewed
May 16, 2025
connector/signaltometricsconnector/internal/aggregator/aggregator.go
Outdated
Show resolved
Hide resolved
lahsivjar
reviewed
May 16, 2025
connector/signaltometricsconnector/internal/aggregator/aggregator.go
Outdated
Show resolved
Hide resolved
- allow for all signals - only support numbers in OTTL expressions rather than Grok maps. - move check into loop
|
@lahsivjar thanks for the initial round of feedback, moving this out of draft now after addressing your feedback. |
lahsivjar
approved these changes
May 16, 2025
Comment on lines
327
to
332
| if strings.Contains(mi.Gauge.Value, "ExtractGrokPatterns") { | ||
| // Ensure a [key] selector is present after ExtractGrokPatterns | ||
| if !regexp.MustCompile(`ExtractGrokPatterns\([^)]*\)\s*\[[^\]]+\]`).MatchString(mi.Gauge.Value) { | ||
| return fmt.Errorf("ExtractGrokPatterns: a single key selector[key] is required for signal to gauge") | ||
| } | ||
| } |
There was a problem hiding this comment.
This check would be true for all configured metric types so maybe in a follow-up PR we can generalize this as a common validation for ExtractGrokPatterns.
There was a problem hiding this comment.
This is not that important though and we can just create an issue and leave it for future too as we might need to think about how to (or if to) handle config validation for all funcs that return map (or other non-primitives)
Co-authored-by: Vishal Raj <[email protected]>
lahsivjar
approved these changes
May 16, 2025
|
@simitt There are some minor lint errors and it also needs a changelog. More details on adding changelog is available here: opentelemetry-collector-contrib/CONTRIBUTING.md Lines 72 to 76 in c37a07f |
lahsivjar
reviewed
May 21, 2025
ChrsMark
reviewed
May 22, 2025
ChrsMark
approved these changes
May 22, 2025
ChrsMark
added
the
ready to merge
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add support for parsing `gauges` from any signal type with last value aggregation per batch. For now only numerical values are supported. Parsing timestamps is not yet supported. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to open-telemetry#37093 <!--Describe what testing was performed and which tests were added.--> #### Testing Automated unit tests have been added. <!--Describe the documentation added.--> #### Documentation README was updated <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Vishal Raj <[email protected]> Co-authored-by: Christos Markou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for parsing
gaugesfrom any signal type with last value aggregation per batch.For now only numerical values are supported. Parsing timestamps is not yet supported.
Link to tracking issue
Relates to #37093
Testing
Automated unit tests have been added.
Documentation
README was updated