Skip to content

add gauge metric support for signaltometrics connector #37093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilad-aperio opened this issue Jan 8, 2025 · 10 comments
Open

add gauge metric support for signaltometrics connector #37093

gilad-aperio opened this issue Jan 8, 2025 · 10 comments
Labels

Comments

@gilad-aperio
Copy link

Component(s)

connector/signaltometrics

Is your feature request related to a problem? Please describe.

Many systems, especially legacy ones, report metrics through logs. Analyzing metric data directly from logs is inefficient and complex, which highlights the need to extract it from the logs during collection and store it as a separate signal. This capability already exists on the receiving end of many monitoring platforms (1, 2, 3) - having it in OTel would greatly enhance it.
The signaltometrics connector is a huge step toward this, but it does not produce the gauge metric type currently. This is a request to add gauge to the list of supported produced metrics.

Describe the solution you'd like

Example configuration:

connectors:
  signaltometrics:
    gauge:
      value: ExtractGrokPatterns(body, "%{TIMESTAMP_ISO8601:timestamp} Memory usage: %{NUMBER:memory_mb:float}MB")

Log: 2025-01-08 16:28:00 Memory usage: 600MB
Result:

[
  {
    "timestamp": "2025-01-08 16:28:00",
    "memory_mb": 600
  }
]

Describe alternatives you've considered

No response

Additional context

No response

@gilad-aperio gilad-aperio added enhancement New feature or request needs triage New item requiring triage labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@lahsivjar
Copy link
Member

Sounds good to me.

@lahsivjar
Copy link
Member

/label -needs-triage

@github-actions github-actions bot removed the needs triage New item requiring triage label Jan 8, 2025
@akstron
Copy link
Contributor

akstron commented Jan 27, 2025

Hi @lahsivjar , I would like to work on it. Can you please assign this to me?

@lahsivjar
Copy link
Member

@akstron I don't think I have the permission to assign it to you but feel free to create a PR as, to my knowledge, no one is working on this right now.

@oshamin
Copy link

oshamin commented Feb 5, 2025

I am also interested in this feature, @akstron have you started working on it?

@akstron
Copy link
Contributor

akstron commented Feb 6, 2025

Hi @oshamin , yes I have. Need few days to send out a PR.

@lahsivjar
Copy link
Member

👋 @akstron , how is the PR coming along? Let me know if you need any input/help.

@oshamin
Copy link

oshamin commented Apr 14, 2025

Any update to the PR?

@lahsivjar
Copy link
Member

I did a spike on something similar for a separate purpose, and I can polish it to create a PR for this issue, but let's wait for an update from @akstron first.

songy23 pushed a commit that referenced this issue May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add support for parsing `gauges` from any signal type with last value
aggregation per batch.
For now only numerical values are supported. Parsing timestamps is not
yet supported.


<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to #37093

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Automated unit tests have been added. 

<!--Describe the documentation added.-->
#### Documentation
README was updated
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Vishal Raj <[email protected]>
Co-authored-by: Christos Markou <[email protected]>
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this issue May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add support for parsing `gauges` from any signal type with last value
aggregation per batch.
For now only numerical values are supported. Parsing timestamps is not
yet supported.


<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Relates to open-telemetry#37093

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Automated unit tests have been added. 

<!--Describe the documentation added.-->
#### Documentation
README was updated
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Vishal Raj <[email protected]>
Co-authored-by: Christos Markou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants