[provider/googlesecretmanagerprovider] mark the component "Alpha" Stability #39956
Conversation
XuechunHou
requested review from
a team,
dashpole,
jsuereth and
braydonk
as code owners
github-actions
bot
added
reports/distributions/contrib.yaml
confmap/provider/googlesecretmanagerprovider
cmd/otelcontribcol
|
Now that this component exists, please ensure to follow the PR title guidelines. |
XuechunHou
changed the title
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: enhancement | |||
There was a problem hiding this comment.
Other alpha component changelogs seem to use new_component so we should use that here too I think.
| change_type: enhancement | |
| change_type: new_component |
There was a problem hiding this comment.
There was a problem hiding this comment.
If the changelog from the previous PR is new_component then we can leave this one as enhancement.
There was a problem hiding this comment.
49a05ab#diff-824a70bad7774ba59c7f93d6564ad3810cf905250bba9c63c1f7577e9bf6dac5R2 If you are referring to this PR, then yes.
reports/distributions/contrib.yaml
Outdated
| @@ -118,6 +118,7 @@ components: | |||
| - transform | |||
| provider: | |||
| - aes | |||
| - googlesecretmanagerprovider | |||
There was a problem hiding this comment.
This has made me realize that in the initial PR I didn't notice provider is in the type field for metadata.yaml of this component. I don't think it should, as other components of any type don't include the type of component in the type name. So we should change that to googlesecretmanager along with any other necessary changes from that
braydonk
added
the
ready to merge
…bility (open-telemetry#39956) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The full implementation of the component is added in : open-telemetry#39790. This PR marks the component "alpha" stability compliant. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#39665 <!--Describe what testing was performed and which tests were added.--> #### Testing [Unit tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/provider_test.go) <!--Describe the documentation added.--> #### Documentation [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/README.md) <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Braydon Kains <[email protected]>
Description
The full implementation of the component is added in : #39790.
This PR marks the component "alpha" stability compliant.
Link to tracking issue
#39665
Testing
Unit tests
Documentation
README