Added a New Provider Component - Google Secrets Provider #39790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Secret Provider
|
|
braydonk
reviewed
May 2, 2025
|
Moving to draft, please address CI and review, and mark ready to review when done. |
XuechunHou
force-pushed
the
main
branch
2 times, most recently
from
93610fd to
5c63ff3
Compare
XuechunHou
force-pushed
the
main
branch
3 times, most recently
from
39cd1f4 to
b5182fc
Compare
braydonk
approved these changes
May 7, 2025
braydonk
added
the
ready to merge
|
Adding |
atoulme
approved these changes
May 8, 2025
This was referenced May 8, 2025
atoulme
pushed a commit
that referenced
this pull request
May 9, 2025
…bility (#39956) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The full implementation of the component is added in : #39790. This PR marks the component "alpha" stability compliant. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue #39665 <!--Describe what testing was performed and which tests were added.--> #### Testing [Unit tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/provider_test.go) <!--Describe the documentation added.--> #### Documentation [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/README.md) <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Braydon Kains <[email protected]>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…try#39790) #### Description This PR adds the full implementation of the Google Secret Provider component. It allows users to securely reference secrets in Otel configurations. This is achieved by replacing plaintext secrets with placeholders in config files; the actual secrets are then retrieved dynamically from Google Secret Manager during the Otel Collector initialization. #### Link to tracking issue open-telemetry#39665 #### Testing Unit tests are added for the `Retrieve` method, and cover the following scenarios: 1. Given an identifier that matches a secret entry stored in Google Secret Manager, Retrieve() returns the corresponding plaintext secret. 2. Given an identifier that does not match any stored secret entry in Google Secret Manager, Retrieve() returns an error. 3. Given an identifier with an invalid scheme, `Retrieve()` should return an error. 4. Given an identifier with invalid opaque_data, `Retrieve()` should return an error. #### Documentation README.md --------- Co-authored-by: Braydon Kains <[email protected]>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…bility (open-telemetry#39956) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The full implementation of the component is added in : open-telemetry#39790. This PR marks the component "alpha" stability compliant. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#39665 <!--Describe what testing was performed and which tests were added.--> #### Testing [Unit tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/provider_test.go) <!--Describe the documentation added.--> #### Documentation [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/README.md) <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Braydon Kains <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the full implementation of the Google Secret Provider component. It allows users to securely reference secrets in Otel configurations. This is achieved by replacing plaintext secrets with placeholders in config files; the actual secrets are then retrieved dynamically from Google Secret Manager during the Otel Collector initialization.
Link to tracking issue
#39665
Testing
Unit tests are added for the
Retrievemethod, and cover the following scenarios:Retrieve()should return an error.Retrieve()should return an error.Documentation
README.md