[receiver/k8sclusterreceiver] Add missing attributes to entities in experimental entity feature #39038
+169
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowing entities Container - container.name - container.uid - k8s.pod.name - k8s.pod.uid Pod - k8s.namespace.name - k8s.pod.name Workload - k8s,namespace.name
k-shaikh
requested review from
dmitryax,
TylerHelmuth,
ChrsMark and
a team
as code owners
|
|
dmitryax
reviewed
Mar 28, 2025
dmitryax
approved these changes
Mar 31, 2025
…match semantic conventions
…me and container.image.tag.
povilasv
reviewed
Apr 3, 2025
| @@ -23,6 +24,9 @@ const ( | |||
| containerKeyStatus = "container.status" | |||
| containerKeyStatusReason = "container.status.reason" | |||
| containerCreationTimestamp = "container.creation_timestamp" | |||
| containerName = "k8s.container.name" | |||
| containerImageName = "container.image.name" | |||
| containerImageTag = "container.image.tag" | |||
There was a problem hiding this comment.
Suggested change
| containerImageTag = "container.image.tag" | |
| containerImageTags = "container.image.tags" |
I think this needs to be alist based on https://opentelemetry.io/docs/specs/semconv/attributes-registry/container/#container-image-tags
There was a problem hiding this comment.
@povilasv , the current struct for sending metadata only allows values of type string. We can change the label to 'container.image.tags' but changing the value to a list will be very big change.
IMO, we can use the label container.image.tag since its also used here
Also even though an image may contain multiple tags the container spec references a specific tag so the multiple tags maybe relevant for the 'Image' entity it may not be relevant for the container entity.
@dmitryax , do you have any opinion?
There was a problem hiding this comment.
Since the collector currently doesn't send any container.image.tags attribute, only container.image.tag, it'd be in inconsistent state sending data that cannot be easily correlated. I believe, in order to migrate from container.image.tag to container.image.tags attribute, we need to apply the changes to all sources consistently via a feature gate, maybe even keeping the old behavior as an option.
povilasv
approved these changes
Apr 7, 2025
|
Good to go |
|
The failing test is unrelated, #39210 |
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
…xperimental entity feature (open-telemetry#39038) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Modified entity payloads to include additional attributes for the following entities. Some of which are mentioned here - Container - k8s.container.name - container.image.name - container.image.tag - k8s.pod.name - k8s.pod.uid - k8s.namespace.name - k8s.node.name Pod - k8s.namespace.name - k8s.pod.name Workload - k8s.namespace.name <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Partially Resolves: open-telemetry#38687 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated unit tests to validate the desired attributes for the mentioned entities are included in the metadata for that entity <!--Describe the documentation added.--> #### Documentation None. <!--Please delete paragraphs that you did not use before submitting.-->
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
…xperimental entity feature (open-telemetry#39038) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Modified entity payloads to include additional attributes for the following entities. Some of which are mentioned here - Container - k8s.container.name - container.image.name - container.image.tag - k8s.pod.name - k8s.pod.uid - k8s.namespace.name - k8s.node.name Pod - k8s.namespace.name - k8s.pod.name Workload - k8s.namespace.name <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Partially Resolves: open-telemetry#38687 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated unit tests to validate the desired attributes for the mentioned entities are included in the metadata for that entity <!--Describe the documentation added.--> #### Documentation None. <!--Please delete paragraphs that you did not use before submitting.-->
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…xperimental entity feature (open-telemetry#39038) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Modified entity payloads to include additional attributes for the following entities. Some of which are mentioned here - Container - k8s.container.name - container.image.name - container.image.tag - k8s.pod.name - k8s.pod.uid - k8s.namespace.name - k8s.node.name Pod - k8s.namespace.name - k8s.pod.name Workload - k8s.namespace.name <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Partially Resolves: open-telemetry#38687 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated unit tests to validate the desired attributes for the mentioned entities are included in the metadata for that entity <!--Describe the documentation added.--> #### Documentation None. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified entity payloads to include additional attributes for the following entities. Some of which are mentioned here -
Container
Pod
Workload
Link to tracking issue
Partially Resolves: #38687
Testing
Updated unit tests to validate the desired attributes for the mentioned entities are included in the metadata for that entity
Documentation
None.