Skip to content

Commit a3eafbd

Browse files
authored
Merge branch 'main' into main
2 parents 6f46fc2 + ead14b9 commit a3eafbd

File tree

31 files changed

+742
-442
lines changed

31 files changed

+742
-442
lines changed

.chloggen/remove-scope.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: azureauthextension
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Use credentials to handle the access token.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [39057]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

.chloggen/stefreceiver.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: new_component
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: stefreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Make the receiver initially code complete
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [38979]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

.github/CODEOWNERS

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cmd/opampsupervisor/ @open-telemetry
2323
cmd/otelcontribcol/ @open-telemetry/collector-contrib-approvers
2424
cmd/oteltestbedcol/ @open-telemetry/collector-contrib-approvers
2525
cmd/telemetrygen/ @open-telemetry/collector-contrib-approvers @mx-psi @codeboten @Erog38
26-
confmap/provider/aesprovider/ @open-telemetry/collector-contrib-approvers @djaglowski @shazlehu
26+
confmap/provider/aesprovider/ @open-telemetry/collector-contrib-approvers @djaglowski
2727
confmap/provider/s3provider/ @open-telemetry/collector-contrib-approvers @Aneurysm9
2828
confmap/provider/secretsmanagerprovider/ @open-telemetry/collector-contrib-approvers @driverpt @atoulme
2929
connector/countconnector/ @open-telemetry/collector-contrib-approvers @djaglowski @jpkrohling
@@ -112,7 +112,7 @@ extension/jaegerremotesampling/ @open-telemetry
112112
extension/k8sleaderelector/ @open-telemetry/collector-contrib-approvers @dmitryax @rakesh-garimella
113113
extension/oauth2clientauthextension/ @open-telemetry/collector-contrib-approvers @pavankrish123 @jpkrohling
114114
extension/observer/ @open-telemetry/collector-contrib-approvers @dmitryax
115-
extension/observer/cfgardenobserver/ @open-telemetry/collector-contrib-approvers @crobert-1 @cemdk @m1rp @jriguera
115+
extension/observer/cfgardenobserver/ @open-telemetry/collector-contrib-approvers @crobert-1 @cemdk @jriguera
116116
extension/observer/dockerobserver/ @open-telemetry/collector-contrib-approvers @MovieStoreGuy
117117
extension/observer/ecsobserver/ @open-telemetry/collector-contrib-approvers @dmitryax
118118
extension/observer/hostobserver/ @open-telemetry/collector-contrib-approvers @MovieStoreGuy
@@ -239,7 +239,7 @@ receiver/githubreceiver/ @open-telemetry
239239
receiver/gitlabreceiver/ @open-telemetry/collector-contrib-approvers @adrielp @atoulme
240240
receiver/googlecloudmonitoringreceiver/ @open-telemetry/collector-contrib-approvers @dashpole @TylerHelmuth @abhishek-at-cloudwerx
241241
receiver/googlecloudpubsubreceiver/ @open-telemetry/collector-contrib-approvers @alexvanboxel
242-
receiver/googlecloudspannerreceiver/ @open-telemetry/collector-contrib-approvers @dashpole @dsimil @KiranmayiB @harishbohara11
242+
receiver/googlecloudspannerreceiver/ @open-telemetry/collector-contrib-approvers @dashpole @dsimil @KiranmayiB
243243
receiver/haproxyreceiver/ @open-telemetry/collector-contrib-approvers @atoulme @MovieStoreGuy
244244
receiver/hostmetricsreceiver/ @open-telemetry/collector-contrib-approvers @dmitryax @braydonk
245245
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/ @open-telemetry/collector-contrib-approvers @dmitryax @braydonk

cmd/githubgen/allowlist.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@ abhishek-at-cloudwerx
22
cemdk
33
driverpt
44
dsimil
5-
harishbohara11
65
heitorganzeli
76
Hemansh31
87
KiranmayiB
9-
m1rp
10-
shazlehu
118
swar8080
129
zpzhuSplunk
1310
h0cheung

cmd/opampsupervisor/README.md

Lines changed: 46 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -4,36 +4,50 @@ This is an implementation of an OpAMP Supervisor that runs a Collector instance
44
is following a design specified [here](./specification/README.md).
55
The design is still undergoing changes, and as such this implementation may change as well.
66

7-
## Experimenting with the supervisor
7+
Binary and container images for the Supervisor are available under tags starting with `cmd/opampsupervisor` [here](https://github.com/open-telemetry/opentelemetry-collector-releases/tags).
88

9-
The supervisor is currently undergoing heavy development and is not ready for any serious use. However, if you would like to test it, you can follow the steps below:
9+
## More information.
1010

11-
1. Download the [opamp-go](https://github.com/open-telemetry/opamp-go) repository, and run the OpAMP example server in the `internal/examples/server` directory.
11+
If you'd like to learn more about OpAMP, see the
12+
[OpAMP specification](https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#open-agent-management-protocol).
13+
For production-ready client and server implementations in Go, see the
14+
[OpAMP Go repository](https://github.com/open-telemetry/opamp-go).
1215

13-
```shell
14-
git clone [email protected]:open-telemetry/opamp-go.git
15-
cd opamp-go/internal/examples/server
16-
go run .
17-
```
16+
If you have questions or would like to participate, we'd love to hear from you.
17+
There is a regular SIG meeting, see the
18+
[meeting notes](https://docs.google.com/document/d/19WA5-ex8rNFIBIyVb5VqMXfWNmUQwppGhN8zBeNG0f4)
19+
for more information. You can also get in touch with us in the
20+
[#otel-opamp](https://cloud-native.slack.com/archives/C02J58HR58R) channel on
21+
the CNCF Slack workspace.
1822

19-
Visit [localhost:4321](http://localhost:4321) to verify that the server is running.
23+
## Using the Supervisor
2024

21-
2. From the Collector contrib repository root, build the Collector:
25+
See tags starting with `cmd/opampsupervisor` for binary and container image
26+
builds of the Supervisor
27+
[here](https://github.com/open-telemetry/opentelemetry-collector-releases/tags).
2228

23-
```shell
24-
make otelcontribcol
25-
```
29+
To use the Supervisor, you will need four things:
2630

27-
3. Run the supervisor in the `cmd/opampsupervisor` directory of Collector contrib repository, substituting `<OS>` for your operating system (`darwin` for MacOS, `linux` or `windows`):
31+
1. A Supervisor binary, which can be obtained through the link above.
32+
2. A Collector binary that you would like to control through the Supervisor.
33+
3. A Supervisor config file. See examples [here](./examples/).
34+
4. A running OpAMP server.
35+
36+
To test the Supervisor with an example server, download the
37+
[opamp-go](https://github.com/open-telemetry/opamp-go) repository, and run the
38+
OpAMP example server in the `internal/examples/server` directory.
2839

2940
```shell
30-
cd cmd/opampsupervisor
31-
go run . --config examples/supervisor_<OS>.yaml
41+
git clone [email protected]:open-telemetry/opamp-go.git
42+
cd opamp-go/internal/examples/server
43+
go run .
3244
```
3345

34-
4. The supervisor should connect to the OpAMP server and start a Collector instance.
46+
Visit [localhost:4321](http://localhost:4321) to verify that the server is running.
47+
3548

3649
## Persistent data storage
50+
3751
The supervisor persists some data to disk in order to mantain state between restarts. The directory where this data is stored may be specified via the supervisor configuration:
3852
```yaml
3953
storage:
@@ -59,34 +73,33 @@ For a list of open issues related to the Supervisor, see [these issues](https://
5973

6074
⚠️: Implemented with caveats
6175

62-
📅: Planned, but no issue to track implementation
63-
6476
### OpAMP capabilities
6577

6678
| OpAMP capability | Status |
6779
|--------------------------------|----------------------------------------------------------------------------------|
6880
| AcceptsRemoteConfig | ✅ |
69-
| ReportsEffectiveConfig | ⚠️ |
81+
| ReportsEffectiveConfig | |
7082
| AcceptsPackages | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34734> |
71-
| ReportsPackageStatuses | 📅 |
72-
| ReportsOwnTraces | 📅 |
73-
| ReportsOwnMetrics | ⚠️ |
74-
| ReportsOwnLogs | 📅 |
75-
| AcceptsOpAMPConnectionSettings | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21043> |
76-
| AcceptsOtherConnectionSettings | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21043> |
77-
| AcceptsRestartCommand | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21077> |
83+
| ReportsPackageStatuses | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38727> |
84+
| ReportsOwnTraces | |
85+
| ReportsOwnMetrics | |
86+
| ReportsOwnLogs | |
87+
| AcceptsOpAMPConnectionSettings | |
88+
| AcceptsOtherConnectionSettings | |
89+
| AcceptsRestartCommand | |
7890
| ReportsHealth | ⚠️ |
91+
| ReportsStatus | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38729> |
7992
| ReportsRemoteConfig | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21079> |
80-
| ReportsAvailableComponents | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/37247> |
93+
| ReportsAvailableComponents | |
8194

8295
### Supervisor specification features
8396

8497
| Feature | Status |
8598
|--------------------------------------------------------------------|----------------------------------------------------------------------------------|
8699
| Offers Supervisor configuration including configuring capabilities | ✅ |
87-
| Starts and stops a Collector using remote configuration | ⚠️ |
88-
| Communicates with OpAMP extension running in the Collector | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21071> |
89-
| Updates the Collector binary | 📅 |
90-
| Configures the Collector to report it's own metrics over OTLP | 📅 |
91-
| Configures the Collector to report it's own logs over OTLP | 📅 |
100+
| Starts and stops a Collector using remote configuration | |
101+
| Communicates with OpAMP extension running in the Collector | |
102+
| Updates the Collector binary | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33947> |
103+
| Configures the Collector to report it's own metrics over OTLP | |
104+
| Configures the Collector to report it's own logs over OTLP | |
92105
| Sanitization or restriction of Collector config | <https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24310> |

cmd/telemetrygen/internal/e2etest/logs_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ func TestGenerateLogs(t *testing.T) {
2525
rCfg := f.CreateDefaultConfig()
2626
endpoint := testutil.GetAvailableLocalAddress(t)
2727
rCfg.(*otlpreceiver.Config).GRPC.NetAddr.Endpoint = endpoint
28+
rCfg.(*otlpreceiver.Config).HTTP = nil
2829
r, err := f.CreateLogs(context.Background(), receivertest.NewNopSettings(f.Type()), rCfg, sink)
2930
require.NoError(t, err)
3031
err = r.Start(context.Background(), componenttest.NewNopHost())

cmd/telemetrygen/internal/e2etest/metrics_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ func TestGenerateMetrics(t *testing.T) {
2525
rCfg := f.CreateDefaultConfig()
2626
endpoint := testutil.GetAvailableLocalAddress(t)
2727
rCfg.(*otlpreceiver.Config).GRPC.NetAddr.Endpoint = endpoint
28+
rCfg.(*otlpreceiver.Config).HTTP = nil
2829
r, err := f.CreateMetrics(context.Background(), receivertest.NewNopSettings(f.Type()), rCfg, sink)
2930
require.NoError(t, err)
3031
err = r.Start(context.Background(), componenttest.NewNopHost())

cmd/telemetrygen/internal/e2etest/traces_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ func TestGenerateTraces(t *testing.T) {
2525
rCfg := f.CreateDefaultConfig()
2626
endpoint := testutil.GetAvailableLocalAddress(t)
2727
rCfg.(*otlpreceiver.Config).GRPC.NetAddr.Endpoint = endpoint
28+
rCfg.(*otlpreceiver.Config).HTTP = nil
2829
r, err := f.CreateTraces(context.Background(), receivertest.NewNopSettings(f.Type()), rCfg, sink)
2930
require.NoError(t, err)
3031
err = r.Start(context.Background(), componenttest.NewNopHost())

confmap/provider/aesprovider/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
| Stability | [alpha] |
77
| Distributions | [contrib] |
88
| Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aprovider%2Faesprovider%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aprovider%2Faesprovider) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aprovider%2Faesprovider%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aprovider%2Faesprovider) |
9-
| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@djaglowski](https://www.github.com/djaglowski), [@shazlehu](https://www.github.com/shazlehu) |
9+
| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@djaglowski](https://www.github.com/djaglowski) |
10+
| Emeritus | [@shazlehu](https://www.github.com/shazlehu) |
1011

1112
[alpha]: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/component-stability.md#alpha
1213
[contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib

confmap/provider/aesprovider/metadata.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ status:
66
alpha: [provider]
77
distributions: [contrib]
88
codeowners:
9-
active: [djaglowski, shazlehu]
9+
active: [djaglowski]
10+
emeritus: [shazlehu]

extension/azureauthextension/README.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<!-- end autogenerated section -->
1212

1313
This extension implements both `extensionauth.HTTPClient` and `extensionauth.Server`, so it can be used in both exporters and receivers.
14+
**Currently, this part is still not implemented.**
1415

1516
Additionally, the extension also implements `azcore.TokenCredential` so that Azure components can get the token by running the function `GetToken`. If the component supports HTTP client, then this should not be necessary, as the token will be placed in the authorization header.
1617

@@ -20,8 +21,6 @@ It supports 4 different types of authentication:
2021
- Service principal with either a client secret or client certificate path for non Azure.
2122
- And the default credentials. This is not recommended for production.
2223

23-
Each type of authentication requires the [scope of the permissions](https://learn.microsoft.com/en-us/entra/identity-platform/scopes-oidc) for the token.
24-
2524
## Examples
2625

2726
### Managed identity
@@ -30,7 +29,6 @@ User based:
3029
```yaml
3130
extensions:
3231
azureauth:
33-
scope: https://management.azure.com/.default
3432
managed_identity:
3533
client_id: ${CLIENT_ID}
3634
```
@@ -39,7 +37,6 @@ System based (leave `client_id` field empty):
3937
```yaml
4038
extensions:
4139
azureauth:
42-
scope: https://management.azure.com/.default
4340
managed_identity:
4441
```
4542

@@ -48,7 +45,6 @@ extensions:
4845
```yaml
4946
extensions:
5047
azureauth:
51-
scope: https://management.azure.com/.default
5248
workload_identity:
5349
client_id: ${CLIENT_ID}
5450
federated_token_file: ${FILE}
@@ -61,7 +57,6 @@ With client secret:
6157
```yaml
6258
extensions:
6359
azureauth:
64-
scope: https://management.azure.com/.default
6560
service_principal:
6661
client_id: ${CLIENT_ID}
6762
tenant_id: ${TENANT_ID}
@@ -72,7 +67,6 @@ With client certificate path:
7267
```yaml
7368
extensions:
7469
azureauth:
75-
scope: https://management.azure.com/.default
7670
service_principal:
7771
client_id: ${CLIENT_ID}
7872
tenant_id: ${TENANT_ID}
@@ -85,6 +79,5 @@ Not recommended for production.
8579
```yaml
8680
extensions:
8781
azureauth:
88-
scope: https://management.azure.com/.default
8982
use_default: true
9083
```

0 commit comments

Comments
 (0)