-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[prometheuswritereceiver] target info #38812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, but there are a few things not going in the right direction. Added a few comments below
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@ArthurSens I adapted the tests to use the forked version that fixes that snappy compression. But now I think that we have a different problem. How we will validate the multiple requests' behavior? This because, the way that you explain to me that this code should be done, is using the Besides that, I think that in the response of the |
The answer was in my front of me the whole time 5a08906#diff-946c2dc5f6b3b6d865be9b13c57625f05b095c373d8dcc960fa4357985903058R519 I can pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome progress, I think we're almost done :)
A few comments
Co-authored-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Arthur Silva Sens <[email protected]>
…tor-contrib into target-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one very small comment, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The hardest part of the mentorship is done 🎉
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding the obs report component The discussion to add this component started [here](#38812 (comment)) The last commit the we reviewed before I screw up the whole branch https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/39828/files/13688834d2674c61ced371b5500abb4e901e8183 --------- Co-authored-by: Arthur Silva Sens <[email protected]>
Description
Cache
target_info
metrics so it can be used to populate metrics' Resource Attributes.Link to tracking issue
Partially fixes #37277