validate expected metric in the end of request

Author: perebaj

receiver/prometheusremotewritereceiver/receiver_test.go

@@ -527,17 +527,19 @@ func TestTargetInfoWithMultipleRequests(t *testing.T) {
 		assert.NoError(t, prwReceiver.Shutdown(context.Background()))
 	}()
 
-	// Define with two different metrics, one is target_info and the other is a normal metric
+	// Define two different metrics, one is target_info and the other is a normal metric.
+	// In the end, we expect that we have 1 final metric. All labels from the target_info metric should be translated to resource attributes and
+	// the normal metric should be translated as usual.
 	requests := []*writev2.Request{
 		{
 			Symbols: []string{
 				"",
-				"job", "production/service_a",
-				"instance", "host1",
-				"machine_type", "n1-standard-1",
-				"cloud_provider", "gcp",
-				"region", "us-central1",
-				"__name__", "target_info",
+				"job", "production/service_a", // 1, 2
+				"instance", "host1", // 3, 4
+				"machine_type", "n1-standard-1", // 5, 6
+				"cloud_provider", "gcp", // 7, 8
+				"region", "us-central1", // 9, 10
+				"__name__", "target_info", // 11, 12
 			},
 			Timeseries: []writev2.TimeSeries{
 				{
@@ -549,10 +551,10 @@ func TestTargetInfoWithMultipleRequests(t *testing.T) {
 		{
 			Symbols: []string{
 				"",
-				"job", "production/service_a",
-				"instance", "host1",
-				"__name__", "normal_metric",
-				"foo", "bar",
+				"job", "production/service_a", // 1, 2
+				"instance", "host1", // 3, 4
+				"__name__", "normal_metric", // 5, 6
+				"foo", "bar", // 7, 8
 			},
 			Timeseries: []writev2.TimeSeries{
 				{
@@ -565,16 +567,12 @@ func TestTargetInfoWithMultipleRequests(t *testing.T) {
 	}
 
 	client := &http.Client{}
-
-	// Send both requests
 	for _, req := range requests {
-		// Marshal and compress
 		pBuf := proto.NewBuffer(nil)
 		err := pBuf.Marshal(req)
 		assert.NoError(t, err)
 		compressedBody := snappy.Encode(nil, pBuf.Bytes())
 
-		// Create and send request
 		httpReq, err := http.NewRequest(
 			http.MethodPost,
 			"http://0.0.0.0:9090/api/v1/write",
@@ -594,33 +592,31 @@ func TestTargetInfoWithMultipleRequests(t *testing.T) {
 		assert.Equal(t, http.StatusNoContent, resp.StatusCode, string(body))
 	}
 
-	// Verify final metrics
-	// expectedMetrics := func() pmetric.Metrics {
-	// 	metrics := pmetric.NewMetrics()
-	// 	rm := metrics.ResourceMetrics().AppendEmpty()
-	// 	attrs := rm.Resource().Attributes()
-	// 	attrs.PutStr("service.namespace", "production")
-	// 	attrs.PutStr("service.name", "service_a")
-	// 	attrs.PutStr("service.instance.id", "host1")
-	// 	attrs.PutStr("machine.type", "n1-standard-1")
-	// 	attrs.PutStr("cloud.provider", "gcp")
-	// 	attrs.PutStr("region", "us-central1")
-
-	// 	sm := rm.ScopeMetrics().AppendEmpty()
-	// 	sm.Scope().SetName("OpenTelemetry Collector")
-	// 	sm.Scope().SetVersion("latest")
-
-	// 	m1 := sm.Metrics().AppendEmpty()
-	// 	m1.SetName("normal_metric")
-	// 	m1.SetUnit("")
-	// 	m1.SetDescription("")
-	// 	dp1 := m1.SetEmptyGauge().DataPoints().AppendEmpty()
-	// 	dp1.SetDoubleValue(2.0)
-	// 	dp1.SetTimestamp(pcommon.Timestamp(2 * int64(time.Millisecond)))
-	// 	dp1.Attributes().PutStr("foo", "bar")
-
-	// 	return metrics
-	// }()
-
-	// assert.NoError(t, pmetrictest.CompareMetrics(expectedMetrics, mockConsumer.metrics[0]))
+	expectedMetrics := func() pmetric.Metrics {
+		metrics := pmetric.NewMetrics()
+		rm := metrics.ResourceMetrics().AppendEmpty()
+		attrs := rm.Resource().Attributes()
+		attrs.PutStr("service.namespace", "production")
+		attrs.PutStr("service.name", "service_a")
+		attrs.PutStr("service.instance.id", "host1")
+		attrs.PutStr("machine.type", "n1-standard-1")
+		attrs.PutStr("cloud.provider", "gcp")
+		attrs.PutStr("region", "us-central1")
+
+		sm := rm.ScopeMetrics().AppendEmpty()
+		sm.Scope().SetName("OpenTelemetry Collector")
+		sm.Scope().SetVersion("latest")
+		m1 := sm.Metrics().AppendEmpty()
+		m1.SetName("normal_metric")
+		m1.SetUnit("")
+		m1.SetDescription("")
+		dp1 := m1.SetEmptyGauge().DataPoints().AppendEmpty()
+		dp1.SetDoubleValue(2.0)
+		dp1.SetTimestamp(pcommon.Timestamp(2 * int64(time.Millisecond)))
+		dp1.Attributes().PutStr("foo", "bar")
+
+		return metrics
+	}()
+
+	assert.NoError(t, pmetrictest.CompareMetrics(expectedMetrics, mockConsumer.metrics[0]))
 }