Skip to content

[filelogreceiver] fix: update logpath regex to include rotated files in container parser #38440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexylew
Copy link
Contributor

@alexylew alexylew commented Mar 6, 2025

Description

Extends log file path pattern in container parser to include rotated log files which are currently being rejected, leading to dropped logs.

Link to tracking issue

Fixes #35137

Testing

Added two test cases to include rotated file log path examples.

@alexylew alexylew requested review from djaglowski and a team as code owners March 6, 2025 19:15
Copy link

linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@djaglowski
Copy link
Member

Please sign the CLA and add a changelog

@alexylew alexylew changed the title fix: update logpath regex to include rotated files in container parser [filelogreceiver] fix: update logpath regex to include rotated files in container parser Mar 10, 2025
@alexylew
Copy link
Contributor Author

@djaglowski CLA signed and changelog added

Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label Mar 13, 2025
@atoulme atoulme merged commit 28807d3 into open-telemetry:main Mar 14, 2025
180 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 14, 2025
@alexylew alexylew deleted the alew/fix-container-parser-logfilepath-pattern branch March 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/filelog] Filelog receiver missing reading log lines in high throughput scenario
5 participants