Skip to content

[receiver/filelog] Retain original file attributes over rotated file attributes #38454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djaglowski opened this issue Mar 7, 2025 · 3 comments

Comments

@djaglowski
Copy link
Member

However, in the container parser specifically the parser checks the file name when it tries to parse each line and if it fails to match the pattern of known log files then it will reject the log line

I think it's worth exploring whether the original file name can be kept, rather than associating the logs with the rotated file. If we'd been a bit faster to read them, they would be, so it seems odd that this should change depending on marginal timing issues.

I'm going to approve #38440 because it offers an immediate solution to this particular situation and doesn't have much downside (presumably just a minor performance hit on the regex eval). However, I'll open another issue describing the change which would resolve the root cause.

Originally posted by @djaglowski in #35137

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Pinging code owners for receiver/filelog: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

Copy link
Contributor

github-actions bot commented May 7, 2025

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant