[receiver/iis] fixed issue #34924 - monitor application pool uptime #38183
Conversation
receiver/iisreceiver/metadata.yaml
Outdated
| unit: "{state}" | ||
| gauge: | ||
| value_type: int | ||
| enabled: true |
There was a problem hiding this comment.
Please set enabled: false for new metrics, and enable them in a second PR as a breaking change.
There was a problem hiding this comment.
done. Should a new PR with the breaking change be created after this is complete (if it gets completed) or can it be created already?
receiver/iisreceiver/metadata.yaml
Outdated
| unit: "{ms}" | ||
| gauge: | ||
| value_type: int | ||
| enabled: true |
|
Please add a changelog. |
Done, I hope I did it correctly. |
|
|
||
| ### iis.application_pool.state | ||
|
|
||
| The current state of the application pool. |
There was a problem hiding this comment.
The state value should document the values per https://learn.microsoft.com/en-us/dotnet/api/microsoft.web.administration.objectstate?view=iis-dotnet#fields or at least link to it. Example:
There was a problem hiding this comment.
Good point, I have updated the metadata file and re-run mdatagen.
| @@ -135,3 +135,15 @@ metrics: | |||
| gauge: | |||
| value_type: int | |||
| enabled: true | |||
| iis.application_pool.state: | |||
| description: The current state of the application pool. (0 - Starting, 1 - Started, 2 - Stopping, 3 - Stopped, 4 - Unknown) | |||
done, however just a generated package test go file was updated. |
pjanotti
added
the
ready to merge
Description
Added new metrics
Link to tracking issue
#34924
Testing
Has been tested on a local windows machine.
Documentation
Metadata documention has been updated by mdatagen.