Skip to content

Commit 201c8db

Browse files
authored
[chore] Remove parallelism to fix race condition (#38189)
I'm seeing the following error in CI on many PRs: ``` Running target 'fmt' in module 'extension/observer/ecsobserver' as part of group 'all' make --no-print-directory -C extension/observer/ecsobserver fmt /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gofumpt -l -w . error: size of generated_package_test.go changed during reading (from 169 to >=170 bytes) make[3]: *** [../../../Makefile.Common:201: fmt] Error 2 ``` Best I can tell this is a race condition between the `fmt` and `generate` targets. This is an attempt to reduce possibility for race condition by reducing parallelism in the check and target that are failing.
1 parent 5f5991f commit 201c8db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ jobs:
222222
git diff -s --exit-code || (echo 'Generated code is out of date, please run "make gendistributions" and commit the changes in this PR.' && exit 1)
223223
- name: CodeGen
224224
run: |
225-
make -j2 generate
225+
make generate
226226
if [[ -n $(git status -s) ]]; then
227227
echo 'Generated code is out of date, please run "make generate" and commit the changes in this PR.'
228228
exit 1

0 commit comments

Comments
 (0)