[processor/tailsampling] Allow invert matches in composite policy to continue processing #36673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…continue processing Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
evan-bradley
approved these changes
Dec 4, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…continue processing (open-telemetry#36673)
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…continue processing (open-telemetry#36673)
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…continue processing (open-telemetry#36673)
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…continue processing (open-telemetry#36673)
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…continue processing (open-telemetry#36673)
atoulme
pushed a commit
that referenced
this pull request
Apr 29, 2025
#### Description
This pull-request introduces a new policy type to explicitly drop traces
regardless of other policy decisions. The new `drop` policy type behaves
much like an `and`, however, it returns a `Dropped` decision when all of
its policies return `Sampled`. A `Dropped` decision takes precedence
over all others. The `Dropped` decision is not new, however, it was
unused and therefor safe to use for this purpose. This new policy type
is very **approachable** and capable.
This new policy type can be used to replace the top-level (not within an
`and` policy) use of `invert_match` to control the final sampling
decision. We could deprecate the current `invert_match` top-level
decision logic. The string, numeric, and boolean filter policies still
support `invert_match`, which continues to flip the decision for the
individual policy. Let `invert_match` be simple.
Example:
```
{
name: drop-it-like-its-hot,
type: drop,
drop: {
drop_sub_policy:
[
{
name: do-not-sample,
type: boolean_attribute,
boolean_attribute: { key: app.do_not_sample, value: true },
}
]
}
}
```
This is a reduced version of a previous PR
#37760
#### Related Issues
-
#36673
-
#33656
-
#36795
-
#34296
-
#34085
-
#29637
-
#27049
- Probably more 😅
---------
Signed-off-by: Sean Porter <[email protected]>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
#### Description
This pull-request introduces a new policy type to explicitly drop traces
regardless of other policy decisions. The new `drop` policy type behaves
much like an `and`, however, it returns a `Dropped` decision when all of
its policies return `Sampled`. A `Dropped` decision takes precedence
over all others. The `Dropped` decision is not new, however, it was
unused and therefor safe to use for this purpose. This new policy type
is very **approachable** and capable.
This new policy type can be used to replace the top-level (not within an
`and` policy) use of `invert_match` to control the final sampling
decision. We could deprecate the current `invert_match` top-level
decision logic. The string, numeric, and boolean filter policies still
support `invert_match`, which continues to flip the decision for the
individual policy. Let `invert_match` be simple.
Example:
```
{
name: drop-it-like-its-hot,
type: drop,
drop: {
drop_sub_policy:
[
{
name: do-not-sample,
type: boolean_attribute,
boolean_attribute: { key: app.do_not_sample, value: true },
}
]
}
}
```
This is a reduced version of a previous PR
open-telemetry#37760
#### Related Issues
-
open-telemetry#36673
-
open-telemetry#33656
-
open-telemetry#36795
-
open-telemetry#34296
-
open-telemetry#34085
-
open-telemetry#29637
-
open-telemetry#27049
- Probably more 😅
---------
Signed-off-by: Sean Porter <[email protected]>
atoulme
pushed a commit
that referenced
this pull request
May 9, 2025
#### Description Users can now use the newly added [Drop policy type](#39668) to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions. This pull-request introduces a feature gate/flag, `processor.tailsamplingprocessor.disableinvertdecisions`, to disable the invert sampling decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still support `invert_match`, which continues to flip the decision for the individual policy (only `Sampled` and `NotSampled`). Letting `invert_match` be simple. #### Related Issues - #36673 - #33656 - #36795 - #34296 - #34085 - #29637 - #27049 - Probably more 😅 --------- Signed-off-by: Sean Porter <[email protected]>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
#### Description
This pull-request introduces a new policy type to explicitly drop traces
regardless of other policy decisions. The new `drop` policy type behaves
much like an `and`, however, it returns a `Dropped` decision when all of
its policies return `Sampled`. A `Dropped` decision takes precedence
over all others. The `Dropped` decision is not new, however, it was
unused and therefor safe to use for this purpose. This new policy type
is very **approachable** and capable.
This new policy type can be used to replace the top-level (not within an
`and` policy) use of `invert_match` to control the final sampling
decision. We could deprecate the current `invert_match` top-level
decision logic. The string, numeric, and boolean filter policies still
support `invert_match`, which continues to flip the decision for the
individual policy. Let `invert_match` be simple.
Example:
```
{
name: drop-it-like-its-hot,
type: drop,
drop: {
drop_sub_policy:
[
{
name: do-not-sample,
type: boolean_attribute,
boolean_attribute: { key: app.do_not_sample, value: true },
}
]
}
}
```
This is a reduced version of a previous PR
open-telemetry#37760
#### Related Issues
-
open-telemetry#36673
-
open-telemetry#33656
-
open-telemetry#36795
-
open-telemetry#34296
-
open-telemetry#34085
-
open-telemetry#29637
-
open-telemetry#27049
- Probably more 😅
---------
Signed-off-by: Sean Porter <[email protected]>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…metry#39833) #### Description Users can now use the newly added [Drop policy type](open-telemetry#39668) to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions. This pull-request introduces a feature gate/flag, `processor.tailsamplingprocessor.disableinvertdecisions`, to disable the invert sampling decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still support `invert_match`, which continues to flip the decision for the individual policy (only `Sampled` and `NotSampled`). Letting `invert_match` be simple. #### Related Issues - open-telemetry#36673 - open-telemetry#33656 - open-telemetry#36795 - open-telemetry#34296 - open-telemetry#34085 - open-telemetry#29637 - open-telemetry#27049 - Probably more 😅 --------- Signed-off-by: Sean Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling [email protected]
Description
The PR #33671 aligned the behavior of the composite policy with the behavior of the processor as a whole, but in the process, caused a breaking change to users relying on exception lists, like one of the examples from the readme. Given that this is affecting a good number of users, we are reverting that behavior, so that we can have more discussions and a better solution.
Link to tracking issue
Fixes #34085