[chore] Add a new Test and refactor code function #25101
Conversation
| @@ -9,7 +9,7 @@ change_type: enhancement | |||
| component: receiver/collectdreceiver | |||
There was a problem hiding this comment.
the format of changlog seems not right? Do you generate this file by make chlog-new?
There was a problem hiding this comment.
btw, I think this pr do not need changelog, since there is no changes in terms of the users
There was a problem hiding this comment.
Ah, it looks like Zeno updated his existing changelog entry. Every PR needs to have its own changelog or no changelog as @fatsheep9146 explains. I agree this PR doesn't need a changelog.
| wantData: []pmetric.Metrics{}, | ||
| } | ||
|
|
||
| t.Run(testInvlidMethodCase.name, func(t *testing.T) { |
There was a problem hiding this comment.
| t.Run(testInvlidMethodCase.name, func(t *testing.T) { | |
| t.Run(testInvalidMethodCase.name, func(t *testing.T) { |
|
|
||
| func testInvalidMethod(t *testing.T, sink *consumertest.MetricsSink) { | ||
|
|
||
| testInvlidMethodCase := testCase{ |
There was a problem hiding this comment.
| testInvlidMethodCase := testCase{ | |
| testInvalidMethodCase := testCase{ |
| testInvalidMethod(t, sink) | ||
| } | ||
|
|
||
| func testInvalidMethod(t *testing.T, sink *consumertest.MetricsSink) { |
There was a problem hiding this comment.
you can add this to the test cases above instead
| t.Run(testInvlidMethodCase.name, func(t *testing.T) { | ||
| sink.Reset() | ||
| req, err := http.NewRequest( | ||
| "GET", |
There was a problem hiding this comment.
Can we parameterize this method as another testCase field instead of adding another test case?
Description:
Add a new test 'testInvalidMethod' in receiver_test.go, and refactor code for readability.
Link to tracking Issue: 20760
Testing: All test pass.