Skip to content

[receiver/collectd] Migrate from OpenCensus data model to pdata #20760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #20762
dmitryax opened this issue Apr 7, 2023 · 5 comments
Closed
Tracked by #20762

[receiver/collectd] Migrate from OpenCensus data model to pdata #20760

dmitryax opened this issue Apr 7, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed receiver/collectd

Comments

@dmitryax
Copy link
Member

dmitryax commented Apr 7, 2023

The receiver still uses OpenCensus data model to create the metrics and converts them into pdata before sending them to the next consumer. This introduces a performance impact. The receiver should use pdata model to create the metrics instead.

@dmitryax dmitryax added enhancement New feature or request needs triage New item requiring triage receiver/collectd labels Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Pinging code owners for receiver/collectd: @atoulme. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax dmitryax added help wanted Extra attention is needed and removed needs triage New item requiring triage labels Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 7, 2023
@dmitryax dmitryax removed the Stale label Jun 7, 2023
@ZenoCC-Peng
Copy link
Contributor

ZenoCC-Peng commented Jul 12, 2023

I would like to work on this!

@ZenoCC-Peng
Copy link
Contributor

ZenoCC-Peng commented Jul 31, 2023

Hi, @atoulme, @dmitryax

I am simply curious about the time.
Currently, I have made some modifications to the code.

The initial implementation of time utilizes the metricspb library, where timestamps are represented as numerical values denoting seconds and nanoseconds.

For example, in the collectd_test.go,

*metricspb.Point{ { Timestamp: &timestamppb.Timestamp{ Seconds: 1415062577, Nanos: 496000000, }, Value: &metricspb.Point_DoubleValue{DoubleValue: 0.2}, } .

However, the pdata version, when we use SetTimestamp to assign timestamps for a datapoint, adopts the UTC time zone format, such as "2014-11-04 00:56:17.496 +0000 UTC,". Although we can covert UTC time zone to numerical values, I am curious whether it is feasible to modify the code to utilize SetTimestamp with UTC time zone. If it is possible, I believe we should include a note in our documentation.

dmitryax pushed a commit that referenced this issue Aug 3, 2023
**Description:**
Migrate from OpenCensus data model to pdata on collectdreceiver. Using
golden to compare metrics for testing.

Since wavefrontreceiver depends on collectdreceiver, adjustments are
necessary in the go.mod and go.sum files.

**Link to tracking Issue:** [20760](#20760)

---------

Co-authored-by: Antoine Toulme <[email protected]>
@dmitryax dmitryax closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed receiver/collectd
Projects
None yet
Development

No branches or pull requests

2 participants