-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[receiver/collectd] Migrate from OpenCensus data model to pdata #20760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for receiver/collectd: @atoulme. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I would like to work on this! |
I am simply curious about the time. The initial implementation of time utilizes the metricspb library, where timestamps are represented as numerical values denoting seconds and nanoseconds. For example, in the collectd_test.go,
However, the pdata version, when we use SetTimestamp to assign timestamps for a datapoint, adopts the UTC time zone format, such as "2014-11-04 00:56:17.496 +0000 UTC,". Although we can covert UTC time zone to numerical values, I am curious whether it is feasible to modify the code to utilize SetTimestamp with UTC time zone. If it is possible, I believe we should include a note in our documentation. |
**Description:** Migrate from OpenCensus data model to pdata on collectdreceiver. Using golden to compare metrics for testing. Since wavefrontreceiver depends on collectdreceiver, adjustments are necessary in the go.mod and go.sum files. **Link to tracking Issue:** [20760](#20760) --------- Co-authored-by: Antoine Toulme <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
The receiver still uses OpenCensus data model to create the metrics and converts them into pdata before sending them to the next consumer. This introduces a performance impact. The receiver should use pdata model to create the metrics instead.
The text was updated successfully, but these errors were encountered: