[provider/googlesecretmanager] schemeName has the word provider in it
#39971
Comments
braydonk
added
needs triage
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
@XuechunHou manual ping for codeowner who isn't in the org yet. |
atoulme
pushed a commit
that referenced
this issue
May 9, 2025
…ecretmanager` instead of `googlesecretmanagerprovider` (#39973) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Updated scheme to use `googlesecretmanager` instead of `googlesecretmanagerprovider` <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #39971 <!--Describe what testing was performed and which tests were added.--> #### Testing [Unit tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/provider_test.go) <!--Describe the documentation added.--> #### Documentation [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/README.md) <!--Please delete paragraphs that you did not use before submitting.-->
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this issue
May 23, 2025
…ecretmanager` instead of `googlesecretmanagerprovider` (open-telemetry#39973) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Updated scheme to use `googlesecretmanager` instead of `googlesecretmanagerprovider` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39971 <!--Describe what testing was performed and which tests were added.--> #### Testing [Unit tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/provider_test.go) <!--Describe the documentation added.--> #### Documentation [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/confmap/provider/googlesecretmanagerprovider/README.md) <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
confmap/provider/googlesecretmanagerprovider
Describe the issue you're reporting
No other providers have
providerin theschemeName, but the scheme for this provider isgooglesecretmanagerprovider. I think it should begooglesecretmanageronly.(Yes I should have noticed this during review)
The text was updated successfully, but these errors were encountered: