migration(Layout): newFooter #5320

AugustinMauroy · 2023-04-21T13:54:32Z

Add footer
Test + snapshot
doest implement on website

vercel · 2023-04-21T13:55:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2023 9:30am
nodejs-org-stories	✅ Ready (Inspect)	Visit Preview		Apr 24, 2023 9:30am

AugustinMauroy · 2023-04-21T17:11:54Z

#5304

components/NewFooter/__tests__/index.test.tsx

components/NewFooter/index.module.scss

ovflowd

Looking good! I added a few comments, but that's pretty much it!

components/NewFooter/index.stories.tsx

Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>

…ejs.org into chore(footer)

components/NewFooter/index.tsx

components/NewFooter/index.stories.tsx

…ejs.org into chore(footer)

components/NewFooter/__tests__/index.test.tsx

ovflowd

LGTM! And I like what I see ✨

ovflowd · 2023-04-22T09:36:46Z

BTW @AugustinMauroy, maybe it's better if we move this component to components/Sections/NewFooter since this is a section.

AugustinMauroy · 2023-04-22T10:16:24Z

Ok @ovflowd i will change that !

components/Sections/NewFooter/index.tsx

ovflowd · 2023-04-23T11:10:23Z

cc @nodejs/website we need another approval :)

Co-authored-by: Claudio Wunder <[email protected]>

* feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore(minor): just a tiny design nitpick * chore: set up storybook (#5191) (#5214) * chore: set up testing-library jest extend (#5231) Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore(dependencies): updated dependencies * feat: create section title component (#5237) Co-authored-by: Wai.Tung <[email protected]> * 📎 chore(migration): migrate banner component (#5233) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate AnimatedPlaceholder component (#5238 Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story. * feat: create article alert component (#5243) * feat: migrate blockquote component (#5259) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat: create article data tag component (#5280) * feat: migrate AuthorList component and add story 🎉 (#5277) Co-authored-by: Michael Esteban <[email protected]> * chore(migration): migrate language selector component (#5266) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: contributing quick fix of example Signed-off-by: Claudio Wunder <[email protected]> * chore: story guide and react spreading Signed-off-by: Claudio Wunder <[email protected]> * chore: remove base styles from old styling * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * fix(package.json) Lint command is missing slashes (#5321 fix(package.json) lint:fix missing slashes * moved `DataTag` to `components/Api` (#5317) Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <[email protected]> * hot-fix: dependency updates and fix dev runtime * chore: updated start command * migration(Layout): newFooter (#5320) Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate EditLink component (#5271) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * feat(blog) Migrate BlogCard component (#5323) Co-authored-by: Michael Esteban <[email protected]> * Issue#5307 - Add framer-motion to the dependency list (#5318) * chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: add remote turbo cache and simplified gh actions cache * chore: updated cache rules * chore: more cache rules --------- Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: fix storybook local development mode (#5335) * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <[email protected]> * chore: migrate releases types (#5324) * hotfix: first element no margin-top * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated dependencies * chore: vercel enable middleware and i18n redirection (#5300) * feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore: set up storybook (#5191) (#5214) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * feat(stability): migrate component * chore(snapshot): update * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fea(stability): update stories + fix * Update components/Api/Stability/index.stories.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix(i18n): update turkish language direction (#5182) * chore: rollback CODEOWNER changes (#5183) * Sync: merge `major/website-redesign` into `main` (#5356) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> * feat(stability): update snapshot * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * code format * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> --------- Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Jatin <[email protected]> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Yagiz Nizipli <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jithil P Ponnan <[email protected]>

AugustinMauroy and others added 3 commits April 21, 2023 15:40

Feat(NewFooter): introduce new footer

1bcc758

feat(NewFooter): add I18n key + icon style

e32bb3d

feat(NewFooter): fix some small thing

c7dbcbb

AugustinMauroy requested a review from a team as a code owner April 21, 2023 13:54

AugustinMauroy changed the base branch from main to major/website-redesign April 21, 2023 13:54

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 13:58 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 13:58 Inactive

Merge branch 'major/website-redesign' into chore(footer)

09575ef

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 14:00 Inactive

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 14:04 Inactive

Merge branch 'major/website-redesign' into chore(footer)

439aac9

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 17:13 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 17:13 Inactive

ovflowd reviewed Apr 21, 2023

View reviewed changes

components/NewFooter/__tests__/index.test.tsx Outdated Show resolved Hide resolved

ovflowd reviewed Apr 21, 2023

View reviewed changes

components/NewFooter/index.module.scss Outdated Show resolved Hide resolved

ovflowd reviewed Apr 21, 2023

View reviewed changes

components/NewFooter/index.stories.tsx Outdated Show resolved Hide resolved

components/NewFooter/index.stories.tsx Outdated Show resolved Hide resolved

components/NewFooter/index.stories.tsx Outdated Show resolved Hide resolved

Update components/NewFooter/index.module.scss

3cef086

Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 17:33 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 17:34 Inactive

AugustinMauroy added 2 commits April 21, 2023 21:06

feat(Header): update with feedback

3690d28

Merge branch 'chore(footer)' of https://github.com/AugustinMauroy/nod…

67f0103

…ejs.org into chore(footer)

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 19:07 Inactive

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 19:08 Inactive

shanpriyan reviewed Apr 21, 2023

View reviewed changes

components/NewFooter/index.tsx Outdated Show resolved Hide resolved

feat(Footer): update with feedback

1a89fd0

vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 20:35 Inactive

vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 20:37 Inactive

ovflowd reviewed Apr 21, 2023

View reviewed changes

components/NewFooter/index.stories.tsx Outdated Show resolved Hide resolved

Merge branch 'major/website-redesign' into chore(footer)

e5a8fde

vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 05:57 Inactive

AugustinMauroy added 2 commits April 22, 2023 07:58

fix: code format

3d87e55

Merge branch 'chore(footer)' of https://github.com/AugustinMauroy/nod…

3898436

…ejs.org into chore(footer)

vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 06:00 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 06:00 Inactive

ovflowd reviewed Apr 22, 2023

View reviewed changes

components/NewFooter/__tests__/index.test.tsx Outdated Show resolved Hide resolved

ovflowd approved these changes Apr 22, 2023

View reviewed changes

feat(footer): change directory

ad82560

vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 10:23 Inactive

vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 10:24 Inactive

ovflowd reviewed Apr 22, 2023

View reviewed changes

components/Sections/NewFooter/index.tsx Outdated Show resolved Hide resolved

fix: change of dir

73e6f58

vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 17:41 Inactive

vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 17:42 Inactive

mikeesto approved these changes Apr 23, 2023

View reviewed changes

Merge branch 'major/website-redesign' into chore(footer)

98d3124

vercel bot temporarily deployed to Preview – nodejs-org April 24, 2023 09:29 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 24, 2023 09:30 Inactive

ovflowd merged commit 17b698f into nodejs:major/website-redesign Apr 24, 2023

u-rogel mentioned this pull request Apr 27, 2023

Redsign/new header #5328

Closed

AugustinMauroy deleted the chore(footer) branch April 28, 2023 20:16

ovflowd added a commit that referenced this pull request May 3, 2023

migration(Layout): newFooter (#5320)

8a86fad

Co-authored-by: Claudio Wunder <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

migration(Layout): newFooter #5320

migration(Layout): newFooter #5320

Uh oh!

AugustinMauroy commented Apr 21, 2023

Uh oh!

vercel bot commented Apr 21, 2023 •

edited

Loading

Uh oh!

AugustinMauroy commented Apr 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Uh oh!

ovflowd commented Apr 22, 2023

Uh oh!

AugustinMauroy commented Apr 22, 2023

Uh oh!

Uh oh!

ovflowd commented Apr 23, 2023

Uh oh!

Uh oh!

Uh oh!

migration(Layout): newFooter #5320

migration(Layout): newFooter #5320

Uh oh!

Conversation

AugustinMauroy commented Apr 21, 2023

Uh oh!

vercel bot commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Apr 22, 2023

Uh oh!

AugustinMauroy commented Apr 22, 2023

Uh oh!

Uh oh!

ovflowd commented Apr 23, 2023

Uh oh!

Uh oh!

vercel bot commented Apr 21, 2023 •

edited

Loading

AugustinMauroy commented Apr 21, 2023 •

edited

Loading