Redsign/new header #5328

u-rogel · 2023-04-24T22:01:20Z

@ovflowd it is way to early to be merged but I have some questions:

In here - _app.mdx we import old styles, can we change to the new ones?
This jsonp - components.header.links.learn, is missing from our i18n schema, do we have a script to add it?
In theme.tsx I needed to comment out this line, otherwise will get an error. Any idea?

feat(unit-test): introduce unit test

Co-authored-by: Manish Kumar ⛄ <[email protected]>

Co-authored-by: Wai.Tung <[email protected]>

Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

…ooks (#5281)

Co-authored-by: Michael Esteban <[email protected]>

chore: next lock to versin 13.2.0

Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>

) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

…mplates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]>

Signed-off-by: Claudio Wunder <[email protected]>

…ies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx

* chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries

fix(package.json) lint:fix missing slashes

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <[email protected]>

u-rogel · 2023-05-02T20:18:18Z

@ovflowd @AugustinMauroy ready for another review I would say.

ovflowd · 2023-05-02T20:25:44Z

components/Sections/NewHeader/index.module.scss

+      min-height: calc(1 * var(--nav-height));
+      padding: 0 var(--space-12);
+    }
+    .startWrapper {


Suggested change

.startWrapper {

.startWrapper {

ovflowd · 2023-05-02T20:41:42Z

@u-rogel code looks nice! But tests failing, probably you need to mock some more stuff!

AugustinMauroy

Nice work 🚀 !

AugustinMauroy · 2023-05-02T20:58:02Z

components/Sections/NewHeader/index.stories.tsx

@@ -0,0 +1,9 @@
+import Header from './index';


We should create stories to see active link.
Useful link: nextjs router storybook

ovflowd · 2023-05-04T13:25:55Z

This PR got accidentally closed because the branch got deleted. Please feel free to reopen the PR.

AugustinMauroy · 2023-05-07T11:18:11Z

Hey 👋 @u-rogel!
Any news ?

u-rogel · 2023-05-07T13:30:43Z

Hey 👋 @u-rogel! Any news ?

Hi, sure will submit something later

AugustinMauroy

Not bad 😁!!!
just don't miss to rebase/chery-pick

AugustinMauroy · 2023-05-07T21:37:28Z

components/Sections/NewHeader/__tests__/index.test.tsx

+
+describe('Tests for Header component', () => {
+  beforeEach(() => {
+    // @ts-ignore


what is the ts error ?

AugustinMauroy · 2023-05-07T21:37:35Z

components/Sections/NewHeader/__tests__/index.test.tsx

+        <Header />
+      </IntlProvider>
+    );
+    expect(container).toMatchSnapshot();


Now we use storybook to create snapshot you should update unit test.

u-rogel · 2023-05-08T16:11:57Z

Not bad 😁!!!
just don't miss to rebase/chery-pick

Will do!

…g into major/website-redesign

u-rogel · 2023-05-08T21:48:41Z

@AugustinMauroy I think I got too far from the target branch. Will create a new PR from the current stage.

AugustinMauroy · 2023-05-08T22:26:55Z

Oh ok no problem !

AugustinMauroy and others added 30 commits April 15, 2023 10:17

feat(unit-test): introduce unit test on website redesign branch (#5178

bd8a46e

feat(unit-test): introduce unit test

chore(redesign): added new folders for new layouts and new pages

80039d3

chore(minor): just a tiny design nitpick

cdbc4b4

chore: set up storybook (#5191) (#5214)

df79868

feat(ignore): add storyBook (#5229)

ecbec61

chore: set up testing-library jest extend (#5231)

a2a4bd8

Co-authored-by: Manish Kumar ⛄ <[email protected]>

chore(dependencies): updated dependencies

67999b6

feat: create section title component (#5237)

48d6c91

Co-authored-by: Wai.Tung <[email protected]>

📎 chore(migration): migrate banner component (#5233)

6ce6923

Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

feat: migrate AnimatedPlaceholder component (#5238

f9d9765

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

feat: create article alert component (#5243)

9311785

chore(dependencies): updated dependencies

06ce22b

fix: formatted file

386a458

chore: updated deps

0240b9b

feat: migrate blockquote component (#5259)

ffa9a3e

feat(stylelint,storybook): fixed styleling misconfig and fixed storyb…

390c2da

…ooks (#5281)

feat: create article data tag component (#5280)

e121b83

feat: migrate AuthorList component and add story 🎉 (#5277)

d7a154d

Co-authored-by: Michael Esteban <[email protected]>

chore: lock nextjs to 13.2.0 (#5301

620f58e

chore: next lock to versin 13.2.0

chore(migration): migrate language selector component (#5266)

79b5134

Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>

feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236

bb46dfe

) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

chore: updated contributing guidelines, eslint rules and storybook te…

bfcabb9

…mplates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]>

chore: contributing quick fix of example

f6dc39f

Signed-off-by: Claudio Wunder <[email protected]>

chore: story guide and react spreading

2eba819

Signed-off-by: Claudio Wunder <[email protected]>

chore: remove base styles from old styling

86b60f3

fix(package.json) Lint command is missing slashes (#5321

5891807

fix(package.json) lint:fix missing slashes

moved DataTag to components/Api (#5317)

ca8b5ab

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <[email protected]>

hot-fix: dependency updates and fix dev runtime

c2aeeaa

ovflowd and others added 2 commits May 2, 2023 22:09

hotfix: first element no margin-top

aa1c542

added missing content from nodejs.dev

ac686af

vercel bot temporarily deployed to Preview – nodejs-org May 2, 2023 20:21 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 2, 2023 20:22 Inactive

ovflowd reviewed May 2, 2023

View reviewed changes

Merge branch 'major/website-redesign' into redsign/new-header

1cbe2f7

vercel bot temporarily deployed to Preview – nodejs-org-stories May 2, 2023 20:27 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 2, 2023 20:29 Inactive

AugustinMauroy reviewed May 2, 2023

View reviewed changes

ovflowd force-pushed the major/website-redesign branch from 7ddfa8d to f2a3ac4 Compare May 3, 2023 23:05

ovflowd deleted the branch nodejs:major/website-redesign May 4, 2023 13:23

ovflowd closed this May 4, 2023

ovflowd reopened this May 4, 2023

test: Mocked availableLocales, tests passing

7ea2989

vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 21:23 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 21:27 Inactive

AugustinMauroy reviewed May 7, 2023

View reviewed changes

u-rogel added 2 commits May 8, 2023 23:20

Merge branch 'major/website-redesign' of github.com:u-rogel/nodejs.or…

8e8ab89

…g into major/website-redesign

Merge branch 'major/website-redesign' into redsign/new-header

b783864

vercel bot temporarily deployed to Preview – nodejs-org-stories May 8, 2023 21:42 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 8, 2023 21:46 Inactive

u-rogel closed this May 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Redsign/new header #5328

Redsign/new header #5328

Uh oh!

u-rogel commented Apr 24, 2023

Uh oh!

u-rogel commented May 2, 2023

Uh oh!

ovflowd May 2, 2023

Uh oh!

ovflowd commented May 2, 2023

Uh oh!

AugustinMauroy left a comment

Uh oh!

AugustinMauroy May 2, 2023

Uh oh!

ovflowd commented May 4, 2023

Uh oh!

AugustinMauroy commented May 7, 2023

Uh oh!

u-rogel commented May 7, 2023

Uh oh!

AugustinMauroy left a comment

Uh oh!

AugustinMauroy May 7, 2023

Uh oh!

AugustinMauroy May 7, 2023

Uh oh!

u-rogel commented May 8, 2023

Uh oh!

u-rogel commented May 8, 2023

Uh oh!

AugustinMauroy commented May 8, 2023

Uh oh!

Uh oh!

Uh oh!

Redsign/new header #5328

Redsign/new header #5328

Uh oh!

Conversation

u-rogel commented Apr 24, 2023

Uh oh!

u-rogel commented May 2, 2023

Uh oh!

ovflowd May 2, 2023

Choose a reason for hiding this comment

Uh oh!

ovflowd commented May 2, 2023

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy May 2, 2023

Choose a reason for hiding this comment

Uh oh!

ovflowd commented May 4, 2023

Uh oh!

AugustinMauroy commented May 7, 2023

Uh oh!

u-rogel commented May 7, 2023

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy May 7, 2023

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy May 7, 2023

Choose a reason for hiding this comment

Uh oh!

u-rogel commented May 8, 2023

Uh oh!

u-rogel commented May 8, 2023

Uh oh!

AugustinMauroy commented May 8, 2023

Uh oh!

Uh oh!