-
Notifications
You must be signed in to change notification settings - Fork 38
Bump iree, mlir-air, mlir-aie #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daveliddell, I just took a look at the failure test which is from AIESerializer.cpp test, and this code is actually no longer in use. We can safely delete those tests. Can you try to update all submodules to latest and try build it again?
Removed tests and associated obsolete code in PR #475. |
Could you bump AIR and (maybe AIE) to latest again? We'd like to include Erwei's latest commits to test conv2d ops. |
Ok, I'll give it a try. |
Signed-off-by: daveliddell <[email protected]>
Signed-off-by: daveliddell <[email protected]>
Signed-off-by: daveliddell <[email protected]>
Signed-off-by: daveliddell <[email protected]>
Thanks! If you haven't started doing a new bump, maybe we can merge this first because it has bump for IREE to unblock @erwei-xilinx. Then we can raise another PR bump mlir-air/aie again. I'm approving now. |
Ok, that's good. I'm happy to do another bump, but I'd rather take it in two steps, in case I encounter more difficulties. Will land this one as soon as CI finishes. Thanks! |
Changes in updated submodules that require adaptation in iree-amd-aie:
NpuWriteBdOp
lost its ddr_id argumentmlir::ceilDiv
and the rest ofmlir/Support/MathExtras.h
was removed in favor of the LLVM equivalents (mlir/MathExtras: consolidate with llvm/MathExtras llvm/llvm-project#95087)