Skip to content

Bump iree, mlir-air, mlir-aie #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Bump iree, mlir-air, mlir-aie #465

merged 4 commits into from
Jun 28, 2024

Conversation

daveliddell
Copy link
Contributor

Changes in updated submodules that require adaptation in iree-amd-aie:

Copy link
Contributor

@yzhang93 yzhang93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daveliddell, I just took a look at the failure test which is from AIESerializer.cpp test, and this code is actually no longer in use. We can safely delete those tests. Can you try to update all submodules to latest and try build it again?

@daveliddell
Copy link
Contributor Author

Hi @daveliddell, I just took a look at the failure test which is from AIESerializer.cpp test, and this code is actually no longer in use. We can safely delete those tests. Can you try to update all submodules to latest and try build it again?

Removed tests and associated obsolete code in PR #475.

@yzhang93
Copy link
Contributor

Could you bump AIR and (maybe AIE) to latest again? We'd like to include Erwei's latest commits to test conv2d ops.

@daveliddell
Copy link
Contributor Author

Could you bump AIR and (maybe AIE) to latest again? We'd like to include Erwei's latest commits to test conv2d ops.

Ok, I'll give it a try.

@yzhang93
Copy link
Contributor

Ok, I'll give it a try.

Thanks! If you haven't started doing a new bump, maybe we can merge this first because it has bump for IREE to unblock @erwei-xilinx. Then we can raise another PR bump mlir-air/aie again. I'm approving now.

@daveliddell
Copy link
Contributor Author

Ok, I'll give it a try.

Thanks! If you haven't started doing a new bump, maybe we can merge this first because it has bump for IREE to unblock @erwei-xilinx. Then we can raise another PR bump mlir-air/aie again. I'm approving now.

Ok, that's good. I'm happy to do another bump, but I'd rather take it in two steps, in case I encounter more difficulties. Will land this one as soon as CI finishes. Thanks!

@daveliddell daveliddell merged commit d34e198 into nod-ai:main Jun 28, 2024
2 checks passed
@daveliddell daveliddell deleted the bump branch June 28, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants