Skip to content

Commit d34e198

Browse files
authored
Bump iree, mlir-air, mlir-aie (#465)
Changes in updated submodules that require adaptation in iree-amd-aie: - `NpuWriteBdOp` lost its ddr_id argument - AIRPipeline.cpp was removed - `mlir::ceilDiv` and the rest of `mlir/Support/MathExtras.h` was removed in favor of the LLVM equivalents (llvm/llvm-project#95087) --------- Signed-off-by: daveliddell <[email protected]>
1 parent 8bfa5f9 commit d34e198

File tree

7 files changed

+8
-11
lines changed

7 files changed

+8
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
run: |
104104
python3 -m venv .venv
105105
source .venv/bin/activate
106-
pip install https://github.com/Xilinx/mlir-aie/releases/download/latest-wheels/mlir_aie-0.0.1.2024061222+3ac9566-py3-none-manylinux_2_35_x86_64.whl
106+
pip install https://github.com/Xilinx/mlir-aie/releases/download/latest-wheels/mlir_aie-0.0.1.2024062422+7917990-py3-none-manylinux_2_35_x86_64.whl
107107
108108
pip install -r tests/matmul/requirements.txt
109109

compiler/plugins/target/AMD-AIE/aie/AIEDmaToNpu.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ struct DmaToNpuPattern : OpConversionPattern<NpuDmaMemcpyNdOp> {
290290

291291
// initialize fields to zero
292292
auto column = zero;
293-
auto ddr_id = zero;
294293
auto bd_id = zero;
295294
auto buffer_length = zero;
296295
auto buffer_offset = zero;
@@ -332,7 +331,7 @@ struct DmaToNpuPattern : OpConversionPattern<NpuDmaMemcpyNdOp> {
332331
// column
333332
column = IntegerAttr::get(i32ty, col);
334333

335-
// ddr_id
334+
// arg_idx
336335
Block &entryBB = op->getParentOfType<func::FuncOp>().getBody().front();
337336
int arg_idx = -1;
338337
for (int i = 0, e = entryBB.getNumArguments(); i < e; i++) {
@@ -342,7 +341,6 @@ struct DmaToNpuPattern : OpConversionPattern<NpuDmaMemcpyNdOp> {
342341
}
343342
}
344343
if (arg_idx < 0) return failure();
345-
ddr_id = IntegerAttr::get(i32ty, arg_idx);
346344

347345
// bd_id
348346
bd_id = IntegerAttr::get(i32ty, op.getId());
@@ -400,7 +398,7 @@ struct DmaToNpuPattern : OpConversionPattern<NpuDmaMemcpyNdOp> {
400398
if (!isMM2S) issue_token = BoolAttr::get(ctx, true);
401399

402400
rewriter.create<NpuWriteBdOp>(
403-
op->getLoc(), column, ddr_id, bd_id, buffer_length, buffer_offset,
401+
op->getLoc(), column, bd_id, buffer_length, buffer_offset,
404402
enable_packet, out_of_order_id, packet_id, packet_type, d0_size,
405403
d0_stride, d1_size, d1_stride, d2_stride, iteration_current,
406404
iteration_size, iteration_stride, next_bd, row, use_next_bd, valid_bd,

compiler/plugins/target/AMD-AIE/air/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ iree_cc_library(
177177
"${IREE_MLIR_AIR_SOURCE_DIR}/lib/Conversion/AIRRtToNpuPass.cpp"
178178
"${IREE_MLIR_AIR_SOURCE_DIR}/lib/Conversion/AIRToAIEPass.cpp"
179179
"${IREE_MLIR_AIR_SOURCE_DIR}/lib/Conversion/AIRToAIESchedulingUtils.cpp"
180-
"${IREE_MLIR_AIR_SOURCE_DIR}/lib/Conversion/AIRPipeline.cpp"
181180
DEPS
182181
::defs
183182
::AIRConversionPassHeaders

compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEControlCodeLoopUnroll.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
#include "iree-amd-aie/IR/AMDAIEOps.h"
88
#include "iree-amd-aie/Transforms/Passes.h"
99
#include "iree-amd-aie/Transforms/Transforms.h"
10+
#include "llvm/Support/MathExtras.h"
1011
#include "mlir/Dialect/SCF/Transforms/Transforms.h"
1112
#include "mlir/Dialect/SCF/Utils/Utils.h"
12-
#include "mlir/Support/MathExtras.h"
1313

1414
#define DEBUG_TYPE "iree-amdaie-controlcode-loop-unroll"
1515

@@ -50,7 +50,7 @@ LogicalResult controlCodeLoopUnroll(RewriterBase &rewriter,
5050
int64_t lbInt = lbCstOp.value();
5151
int64_t ubInt = ubCstOp.value();
5252
int64_t stepInt = stepCstOp.value();
53-
int64_t tripCount = mlir::ceilDiv(ubInt - lbInt, stepInt);
53+
int64_t tripCount = llvm::divideCeilSigned(ubInt - lbInt, stepInt);
5454
if (failed(loopUnrollByFactor(forOp, tripCount))) {
5555
forOp.emitOpError() << "failed to unroll scf.for";
5656
return WalkResult::interrupt();

sync_deps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
### Update with: shark-workspace pin
88

99
PINNED_VERSIONS = {
10-
"iree": "42ac74291a81f495d9b34fcf444bf4b23b5a7966",
10+
"iree": "36aec8a79cc616d126fe50f213d8b93ef298d6ba",
1111
}
1212

1313
ORIGINS = {

third_party/mlir-aie

Submodule mlir-aie updated 59 files

third_party/mlir-air

Submodule mlir-air updated 183 files

0 commit comments

Comments
 (0)