Fix warning when run test #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixing warning when run test. ``` ❯ bundle exec rake /Users/ydah/newrelic-ruby-agent/test/new_relic/agent/configuration/default_source_test.rb:313: warning: assigned but unused variable - default /Users/ydah/newrelic-ruby-agent/test/new_relic/agent/configuration/sampler_config_validator_test.rb:46: warning: assigned but unused variable - config_value /Users/ydah/newrelic-ruby-agent/test/new_relic/agent/datastores_test.rb:188: warning: assigned but unused variable - elapsed /Users/ydah/newrelic-ruby-agent/test/new_relic/agent/transaction/distributed_tracing_test.rb:590: warning: assigned but unused variable - parent_priority /Users/ydah/newrelic-ruby-agent/test/new_relic/agent/transaction/distributed_tracing_test.rb:663: warning: assigned but unused variable - parent_sampled /Users/ydah/newrelic-ruby-agent/test/new_relic/dependency_detection_test.rb:477: warning: assigned but unused variable - execution_took_place /Users/ydah/newrelic-ruby-agent/test/new_relic/newrelicyml_test.rb:115: warning: assigned but unused variable - config_hash ```
github-actions
bot
added
the
community
hannahramadan
previously approved these changes
Dec 31, 2025
Contributor
hannahramadan
left a comment
hannahramadan
left a comment
There was a problem hiding this comment.
Thank you for this cleanup 🫧
hannahramadan
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixing warning when run test.
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist