Merge pull request #3384 from ydah/suppress_warn

Fix warning when run test

Author: hannahramadan

test/new_relic/agent/configuration/default_source_test.rb

@@ -310,7 +310,6 @@ def test_enforce_boolean_uses_default_on_invalid_value
 
     def test_enforce_boolean_logs_warning_on_invalid_value
       key = :'send_data_on_exit'
-      default = ::NewRelic::Agent::Configuration::DefaultSource.default_for(key)
 
       with_config(key => 'yikes!') do
         NewRelic::Agent::Configuration::Manager.stub_const(:USER_CONFIG_CLASSES, [DottedHash]) do

test/new_relic/agent/configuration/sampler_config_validator_test.rb

@@ -43,8 +43,6 @@ def test_validate_sampling_ratio_returns_nil_for_out_of_range
 
     def test_root_strategy_with_valid_ratio_returns_trace_id_ratio_based
       with_config(:'distributed_tracing.sampler.root.trace_id_ratio_based.ratio' => 0.5) do
-        config_value = NewRelic::Agent.config[:'distributed_tracing.sampler.root']
-
         transform = SamplerConfigValidator.validate_sampler_strategy_with_ratio(
           :'distributed_tracing.sampler.root',
           :'distributed_tracing.sampler.root.trace_id_ratio_based.ratio'

test/new_relic/agent/datastores_test.rb

@@ -185,7 +185,6 @@ def test_notice_statement
 
   def test_dont_notice_statement_based_on_record_sql_setting
     query = 'key'
-    elapsed = 1.0
 
     agent = NewRelic::Agent.instance
     agent.transaction_sampler.expects(:notice_nosql_statement).never

test/new_relic/agent/transaction/distributed_tracing_test.rb

@@ -587,15 +587,13 @@ def test_root_transaction_with_trace_id_ratio_based_sampler
 
         def test_trace_id_remains_consistent_across_distributed_trace_with_ratio_sampler
           parent_trace_id = nil
-          parent_priority = nil
           parent_payload = nil
 
           with_config(:'distributed_tracing.sampler.root' => 'trace_id_ratio_based',
             :'distributed_tracing.sampler.root.trace_id_ratio_based.ratio' => 0.5) do
             # Create parent transaction
             in_transaction('parent_txn') do |parent_txn|
               parent_trace_id = parent_txn.trace_id
-              parent_priority = parent_txn.priority
               parent_payload = parent_txn.distributed_tracer.create_distributed_trace_payload
             end
 
@@ -660,7 +658,6 @@ def test_trace_id_ratio_based_remote_parent_not_sampled
 
         def test_multi_hop_distributed_trace_with_trace_id_ratio_based
           grandparent_trace_id = nil
-          parent_sampled = nil
           grandparent_payload = nil
           parent_payload = nil
 
@@ -676,7 +673,6 @@ def test_multi_hop_distributed_trace_with_trace_id_ratio_based
             # Parent transaction accepts grandparent payload
             in_transaction('parent_txn') do |parent_txn|
               parent_txn.distributed_tracer.accept_distributed_trace_payload(grandparent_payload.text)
-              parent_sampled = parent_txn.sampled?
               parent_payload = parent_txn.distributed_tracer.create_distributed_trace_payload
             end
 

test/new_relic/dependency_detection_test.rb

@@ -474,7 +474,7 @@ def test_already_executed_items_are_not_executed_again
     unexecuted.expect :executed, false
     unexecuted.expect :dependencies_satisfied?, true
     unexecuted.expect :disabled_configured?, false
-    unexecuted.expect :execute, -> { execution_took_place = true }
+    unexecuted.expect :execute, -> {}
     executed = Minitest::Mock.new
     executed.expect :executed, true
     unexecuted.expect :disabled_configured?, false

test/new_relic/newrelicyml_test.rb

@@ -112,7 +112,7 @@ def test_build_string
   }
 
   def final_config_hash
-    config_hash = [
+    [
       {
         :begonia => {
           :description => '  # If true, green with white polka dots.',