Skip to content

Fix error category #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigmontz merged 8 commits into from
Jun 10, 2022
Merged

Fix error category #466

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b785491
Fix error category
fbiville Jun 2, 2022
0a342ad
Replace leftover error categories
fbiville Jun 8, 2022
1aa7e85
Fix wrong classification for error types
bigmontz Jun 9, 2022
fc9a8d8
Add driver exceptions to neo4j.test_tx_func#test_tx_timeout
fbiville Jun 9, 2022
4699e42
Verify server version for checking exception code transformation
bigmontz Jun 10, 2022
05d17c9
Fixing the ifs for failure code transformation
bigmontz Jun 10, 2022
74e287e
Fix bug detection verification for `test_tx_func_run`
bigmontz Jun 10, 2022
8963bf9
Fix conditions in test_tx_func_run
bigmontz Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions tests/neo4j/test_tx_func_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,20 @@ def update2(tx):
with self.assertRaises(types.DriverError) as e:
tx.run("MATCH (a:Node) SET a.property = 2").consume()
exc = e.exception
if (exc.code
# TODO REMOVE THIS BLOCK ONCE ALL IMPLEMENT RETRYABLE EXCEPTIONS
if (get_driver_name() in ["javascript", "ruby", "python"]
Copy link
Contributor

@robsdedude robsdedude Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to not put Ruby in there? Once the community driver implements the 5.0 changes, I think it should be notified of this required change through a failing pipeline.

and exc.code
!= "Neo.TransientError.Transaction.LockClientStopped"):
# This is not the error we are looking for. Maybe there was a
# leader election or so. Give the driver the chance to retry.
raise exc
else:
elif exc.code != "Neo.ClientError.Transaction.LockClientStopped":
# This is not the error we are looking for. Maybe there was a
# leader election or so. Give the driver the chance to retry.
raise exc
# The error we are looking for. Raise ApplicationError instead
# to make the driver stop retrying.
else:
raise ApplicationCodeError("Stop, hammer time!")

exc = None
Expand All @@ -221,8 +227,17 @@ def update2(tx):
)
self._session1.write_transaction(update1)
self.assertIsInstance(exc, types.DriverError)
self.assertEqual(exc.code,
"Neo.TransientError.Transaction.LockClientStopped")
if get_driver_name() in ["python"]:
self.assertEqual(exc.errorType,
"<class 'neo4j.exceptions.TransientError'>")
# TODO REMOVE THIS BLOCK ONCE ALL IMPLEMENT RETRYABLE EXCEPTIONS
if get_driver_name() in ["javascript", "ruby", "python"]:
self.assertEqual(
exc.code,
"Neo.TransientError.Transaction.LockClientStopped")
if get_driver_name() in ["python"]:
self.assertEqual(exc.errorType,
"<class 'neo4j.exceptions.TransientError'>")
else:
self.assertEqual(exc.code,
"Neo.ClientError.Transaction.LockClientStopped")
if get_driver_name() in ["python"]:
self.assertEqual(exc.errorType,
"<class 'neo4j.exceptions.ClientError'>")