Fix error category #466
Merged
Fix error category #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LockClientStopped` was misclassified as a transient error, this has been fixed in neo-technology/neo4j#15569
robsdedude
reviewed
Jun 3, 2022
Contributor
|
Judging by the failing pipelines here, there might be more error codes to adjust. Let me have a look. |
fbiville
commented
Jun 3, 2022
Contributor
|
The four failing Python pipelines are to be expected. From my side, this PR can be merged. |
fbiville
commented
Jun 8, 2022
fbiville
force-pushed
the
fix_tx_timeout_test
branch
from
762166b to
0a342ad
Compare
Contributor
Author
|
Rebased and fixed the leftovers |
AndyHeap-NeoTech
approved these changes
Jun 8, 2022
Co-authored-by: Florent Biville <[email protected]>
robsdedude
reviewed
Jun 9, 2022
tests/neo4j/test_session_run.py
Outdated
Comment on lines
159
to
165
| if get_driver_name() in ["javascript", "ruby", "python"]: | ||
| self.assertEqual( | ||
| e.exception.code, | ||
| "Neo.TransientError.Transaction.LockClientStopped") | ||
| "Neo.ClientError.Transaction.LockClientStopped") | ||
| if get_driver_name() in ["python"]: | ||
| self.assertEqual(e.exception.errorType, | ||
| "<class 'neo4j.exceptions.TransientError'>") |
Contributor
There was a problem hiding this comment.
Suggested change
| if get_driver_name() in ["javascript", "ruby", "python"]: | |
| self.assertEqual( | |
| e.exception.code, | |
| "Neo.TransientError.Transaction.LockClientStopped") | |
| "Neo.ClientError.Transaction.LockClientStopped") | |
| if get_driver_name() in ["python"]: | |
| self.assertEqual(e.exception.errorType, | |
| "<class 'neo4j.exceptions.TransientError'>") | |
| if get_driver_name() in ["javascript", "ruby"]: | |
| self.assertEqual( | |
| e.exception.code, | |
| "Neo.ClientError.Transaction.LockClientStopped") |
robsdedude
reviewed
Jun 9, 2022
tests/neo4j/test_tx_run.py
Outdated
Comment on lines
324
to
330
| if get_driver_name() in ["javascript", "ruby", "python"]: | ||
| self.assertEqual( | ||
| e.exception.code, | ||
| "Neo.TransientError.Transaction.LockClientStopped") | ||
| "Neo.ClientError.Transaction.LockClientStopped") | ||
| if get_driver_name() in ["python"]: | ||
| self.assertEqual(e.exception.errorType, | ||
| "<class 'neo4j.exceptions.TransientError'>") |
Contributor
There was a problem hiding this comment.
Suggested change
| if get_driver_name() in ["javascript", "ruby", "python"]: | |
| self.assertEqual( | |
| e.exception.code, | |
| "Neo.TransientError.Transaction.LockClientStopped") | |
| "Neo.ClientError.Transaction.LockClientStopped") | |
| if get_driver_name() in ["python"]: | |
| self.assertEqual(e.exception.errorType, | |
| "<class 'neo4j.exceptions.TransientError'>") | |
| if get_driver_name() in ["javascript", "ruby"]: | |
| self.assertEqual( | |
| e.exception.code, | |
| "Neo.ClientError.Transaction.LockClientStopped") |
fbiville
force-pushed
the
fix_tx_timeout_test
branch
from
1e3ba35 to
fc9a8d8
Compare
robsdedude
reviewed
Jun 10, 2022
tests/neo4j/test_tx_func_run.py
Outdated
| exc = e.exception | ||
| if (exc.code | ||
| # TODO REMOVE THIS BLOCK ONCE ALL IMPLEMENT RETRYABLE EXCEPTIONS | ||
| if (get_driver_name() in ["javascript", "ruby", "python"] |
Contributor
There was a problem hiding this comment.
May I suggest to not put Ruby in there? Once the community driver implements the 5.0 changes, I think it should be notified of this required change through a failing pipeline.
bigmontz
force-pushed
the
fix_tx_timeout_test
branch
from
fc55a06 to
05d17c9
Compare
Co-authored-by: Florent Biville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LockClientStoppedwas misclassified as a transient error,this has been fixed in https://github.com/neo-technology/neo4j/pull/15569