Improve and expand bar aggregation docs #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
changed the title
|
Really great work @stefansimik and @faysou ! Cleared up all doubts I had, especially regarding quotes and how tick-level data can be used. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
New documentation about bar aggregation.
🥇
Credit primarily belongs to @faysou , as he's the one who explained it to me so it finally made sense.
I couldn't figure out how the bar-aggregation functionality really works
without his valuable knowledge and time invested to help me & the community 🙏
Type of change
How has this change been tested?
✅ pre-commit checks passed
✅ documentation was read by me to ensure new content has good logical flow