-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
chore: migrate ESLint config to flat config #5060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshuaKGoldberg
merged 3 commits into
mochajs:master
from
JoshuaKGoldberg:eslint-config-flat
Feb 9, 2024
Merged
chore: migrate ESLint config to flat config #5060
JoshuaKGoldberg
merged 3 commits into
mochajs:master
from
JoshuaKGoldberg:eslint-config-flat
Feb 9, 2024
+388
−1,401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f10375 to
992e08c
Compare
This was referenced Dec 28, 2023
voxpelli
reviewed
Jan 2, 2024
Member
voxpelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into this, it's on my todo to do for standard
17 tasks
Uzlopak
approved these changes
Jan 15, 2024
Member
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a merge conflict in package-lock.
5 tasks
This was referenced Jul 28, 2024
This was referenced Aug 11, 2024
This was referenced Oct 23, 2024
5 tasks
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Migrates from the old
.eslintrc.ymlto a neweslint.config.jsper the new ESLint flat config. Applies a few touchups in the process:package.jsonreferences to ESLint plugins that weren't being used anymoreeslint-plugin-import: 🛠 Repo: Enable eslint-plugin-import in ESLint config #5062eslint-plugin-node(noweslint-plugin-n): 🛠 Repo: Enable eslint-plugin-n in ESLint config #5063eslint-plugin-promise: 🛠 Repo: Enable eslint-plugin-promise in ESLint config #5064npm run lintscript in thepackage.jsonci.ymlthat runs thatlintscript, per 🛠️ Repo: Switch automations to GitHub Actions (GHA) #4117@babel/eslint-parseras it's not necessaryprettierandsemistandardplugins/configsIntentionally doesn't extend from
eslint:recommended, as that change is likely to cause a lot more noise. I split that out into #5061.