🛠 Repo: Enable ESLint's recommended rules for JS

[JoshuaKGoldberg]

Tooling Suggestion Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
• I have searched for related issues and issues with the faq label, but none matched my issue.
• I want to provide a PR to resolve this

Overview

Back in #5060, I'd added an ESLint config but not enabled any of the recommended rules from js.configs.recommended. The rules object is overridden by our custom settings:

mocha/eslint.config.js

Lines 11 to 26 in 3c191c0

	module.exports = [
	{
	...js.configs.recommended,
	languageOptions: {
	ecmaVersion: 2020,
	globals: {
	...globals.browser,
	...globals.node
	},
	sourceType: 'script'
	},
	rules: {
	'no-var': 'off',
	strict: ['error', 'global']
	}
	},

Additional Info

The fact that I missed this and no reviewers caught it is a testament to the ... joy of being new adopters of flat config. 🙃

[voxpelli]

Perhaps we could go with https://github.com/neostandard/neostandard as a base? Considering that semistandard was what was used before #5060 and neostandard now is an option?

[JoshuaKGoldberg]

I'm tentatively in favor, but haven't dug into neostandard enough to have a super informed opinion. Is it a superset of ESLint's recommended JS rules, roughly? From what I've seen it seems like it'd be a good next step after this?

[Uzlopak]

I think we should move to neostandard.

[JoshuaKGoldberg]

Following up: since we're already on ESLint, I'm going to go ahead and push #5282 forward. But if someone wants to file an issue around moving to Neostandard I'd be very interested in hearing more. I don't use it myself and haven't kept good track of its latest happenings.

[voxpelli]

Thoughts on neostandard @mark-wiemer?

[mark-wiemer]

neostandard is foreign to me but I've skimmed through their readme and whatnot. Biggest concerns are that it's not in v1 and doesn't get super frequent updates nowadays. I do think it's worth exploring more, hence #5301, but I think the "ESLint recommended" ruleset will solve 90% of our problems, so we should merge that for now as an incremental improvement

[voxpelli]

Biggest concerns are that it's not in v1 and doesn't get super frequent updates nowadays.

I'm the lead maintainer of it 😜