Skip to content

NetworkPkg: Handle UDP4 polling failures #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makubacki wants to merge 1 commit into
base: release/202502
Choose a base branch
from
+9 −1
Open

NetworkPkg: Handle UDP4 polling failures #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,15 @@ EfiDhcp4Start (

if (CompletionEvent == NULL) {
while (DhcpSb->IoStatus == EFI_ALREADY_STARTED) {
DhcpSb->UdpIo->Protocol.Udp4->Poll (DhcpSb->UdpIo->Protocol.Udp4);
// MU_CHANGE [BEGIN] - Add Udp4 Polling break support
Status = DhcpSb->UdpIo->Protocol.Udp4->Poll (DhcpSb->UdpIo->Protocol.Udp4);
if (EFI_ERROR (Status)) {
Copy link
Contributor

@cfernald cfernald Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to catch things like EFI_DEIVCE_ERROR? Should this have an exception for EFI_TIMEOUT?

Copy link
Member Author

@makubacki makubacki Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the goal is to use the Poll() return code to prevent the system from hanging in the loop if polling encounters an error. I'll check if an exception for EFI_TIMEOUT should be added.

// Break out if the NIC goes away or poll fails so we don't spin forever.
DhcpSb->IoStatus = Status;
break;
}

// MU_CHANGE [END] - Add Udp4 Polling break support
}

return DhcpSb->IoStatus;
Expand Down