NetworkPkg: Handle UDP4 polling failures #1595
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EfiDhcp4Start()` would spin forever if `DhcpSb->IoStatus` is not updated from `EFI_ALREADY_STARTED`. This change captures the poll status (instead of ignoring it) and break out on failures so scenarios like unplug/media-loss return an error instead of hanging. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
networkpkg_dhcp4dxe_udp_poll_break
branch
from
a3f22d4 to
d39e686
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1595 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 71951
Branches ? 1750
================================================
Hits ? 402
Misses ? 71542
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfernald
reviewed
Dec 12, 2025
| DhcpSb->UdpIo->Protocol.Udp4->Poll (DhcpSb->UdpIo->Protocol.Udp4); | ||
| // MU_CHANGE [BEGIN] - Add Udp4 Polling break support | ||
| Status = DhcpSb->UdpIo->Protocol.Udp4->Poll (DhcpSb->UdpIo->Protocol.Udp4); | ||
| if (EFI_ERROR (Status)) { |
Contributor
There was a problem hiding this comment.
Is the intention to catch things like EFI_DEIVCE_ERROR? Should this have an exception for EFI_TIMEOUT?
Member
Author
There was a problem hiding this comment.
Yeah, the goal is to use the Poll() return code to prevent the system from hanging in the loop if polling encounters an error. I'll check if an exception for EFI_TIMEOUT should be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EfiDhcp4Start()would spin forever ifDhcpSb->IoStatusis not updated fromEFI_ALREADY_STARTED.This change captures the poll status (instead of ignoring it) and break out on failures so scenarios like unplug/media-loss return an error instead of hanging.
How This Was Tested
Integration Instructions