Skip to content

[MaterialDatePicker] Fix excessive whitespace #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Orthae wants to merge 1 commit into from
Closed

[MaterialDatePicker] Fix excessive whitespace #2162

Orthae wants to merge 1 commit into from

Conversation

@Orthae
Copy link
Contributor

@Orthae Orthae commented Apr 3, 2021 •
edited
Loading

  • Identify the component the PR relates to in brackets in the title.
    [Buttons] Updated documentation
  • Link to GitHub issues it solves. closes #1234
  • Sign the CLA bot. You can do this once the pull request is opened.

Moved the setting of minimal height from the dialog to the calendar itself. Not sure if I should rename getDialogPickerHeight -> getCalendarHeight.

Closes #2161

device-2021-04-03-184323.mp4
device-2021-04-03-184626.mp4
device-2021-04-03-184728.mp4

@google-cla google-cla bot added the cla: yes label Apr 3, 2021
@langsmith langsmith mentioned this pull request Jun 2, 2021
Closed
@kassim kassim mentioned this pull request Jun 2, 2021
Closed
@awat-langoe awat-langoe mentioned this pull request Jun 22, 2021
Closed
drchen
drchen approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@drchen drchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

slavonnet pushed a commit to slavonnet/material-components-android that referenced this pull request Sep 2, 2021
@Orthae @slavonnet
[MaterialDatePicker] Fix excessive whitespace
87e4142 
Resolves material-components#2162
Resolves material-components#2161

GIT_ORIGIN_REV_ID=9d272c4563f354bedcb0342957ebb2207bceecdf
PiperOrigin-RevId: 394235301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drchen drchen drchen approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MaterialDatePicker] excessive whitespace in input date.

2 participants

@Orthae @drchen