Skip to content

Commit 8fda897

Browse files
Orthaeleticiarossi
authored andcommitted
[MaterialDatePicker] Fix excessive whitespace
Resolves #2162 Resolves #2161 GIT_ORIGIN_REV_ID=9d272c4563f354bedcb0342957ebb2207bceecdf PiperOrigin-RevId: 394235301
1 parent b778645 commit 8fda897

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

lib/java/com/google/android/material/datepicker/MaterialCalendar.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import com.google.android.material.R;
1919

2020
import android.content.Context;
21+
import android.content.res.Resources;
2122
import android.graphics.Canvas;
2223
import android.os.Build.VERSION;
2324
import android.os.Build.VERSION_CODES;
@@ -147,6 +148,7 @@ public View onCreateView(
147148
}
148149

149150
View root = themedInflater.inflate(layout, viewGroup, false);
151+
root.setMinimumHeight(getDialogPickerHeight(requireContext()));
150152
GridView daysHeader = root.findViewById(R.id.mtrl_calendar_days_of_week);
151153
ViewCompat.setAccessibilityDelegate(
152154
daysHeader,
@@ -456,6 +458,23 @@ public void run() {
456458
});
457459
}
458460

461+
private static int getDialogPickerHeight(@NonNull Context context) {
462+
Resources resources = context.getResources();
463+
int navigationHeight =
464+
resources.getDimensionPixelSize(R.dimen.mtrl_calendar_navigation_height)
465+
+ resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_navigation_top_padding)
466+
+ resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_navigation_bottom_padding);
467+
int daysOfWeekHeight =
468+
resources.getDimensionPixelSize(R.dimen.mtrl_calendar_days_of_week_height);
469+
int calendarHeight =
470+
MonthAdapter.MAXIMUM_WEEKS
471+
* resources.getDimensionPixelSize(R.dimen.mtrl_calendar_day_height)
472+
+ (MonthAdapter.MAXIMUM_WEEKS - 1)
473+
* resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_month_vertical_padding);
474+
int calendarPadding = resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_bottom_padding);
475+
return navigationHeight + daysOfWeekHeight + calendarHeight + calendarPadding;
476+
}
477+
459478
@NonNull
460479
LinearLayoutManager getLayoutManager() {
461480
return (LinearLayoutManager) recyclerView.getLayoutManager();

lib/java/com/google/android/material/datepicker/MaterialDatePicker.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,8 @@ public final View onCreateView(
215215
new LayoutParams(getPaddedPickerWidth(context), LayoutParams.WRAP_CONTENT));
216216
} else {
217217
View pane = root.findViewById(R.id.mtrl_calendar_main_pane);
218-
View frame = root.findViewById(R.id.mtrl_calendar_frame);
219218
pane.setLayoutParams(
220219
new LayoutParams(getPaddedPickerWidth(context), LayoutParams.MATCH_PARENT));
221-
frame.setMinimumHeight(getDialogPickerHeight(requireContext()));
222220
}
223221

224222
headerSelectionText = root.findViewById(R.id.mtrl_picker_header_selection_text);
@@ -429,23 +427,6 @@ static boolean readMaterialCalendarStyleBoolean(@NonNull Context context, int at
429427
return attributeValue;
430428
}
431429

432-
private static int getDialogPickerHeight(@NonNull Context context) {
433-
Resources resources = context.getResources();
434-
int navigationHeight =
435-
resources.getDimensionPixelSize(R.dimen.mtrl_calendar_navigation_height)
436-
+ resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_navigation_top_padding)
437-
+ resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_navigation_bottom_padding);
438-
int daysOfWeekHeight =
439-
resources.getDimensionPixelSize(R.dimen.mtrl_calendar_days_of_week_height);
440-
int calendarHeight =
441-
MonthAdapter.MAXIMUM_WEEKS
442-
* resources.getDimensionPixelSize(R.dimen.mtrl_calendar_day_height)
443-
+ (MonthAdapter.MAXIMUM_WEEKS - 1)
444-
* resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_month_vertical_padding);
445-
int calendarPadding = resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_bottom_padding);
446-
return navigationHeight + daysOfWeekHeight + calendarHeight + calendarPadding;
447-
}
448-
449430
private static int getPaddedPickerWidth(@NonNull Context context) {
450431
Resources resources = context.getResources();
451432
int padding = resources.getDimensionPixelOffset(R.dimen.mtrl_calendar_content_padding);

0 commit comments

Comments
 (0)