Skip to content

Add missing dev dependencies #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cmuench
Copy link

@cmuench cmuench commented May 15, 2018

Cloud edition "composer install" does not fetch the --dev dependencies of required packages.
That is the desired behavior of composer.
Every meta-package must resolve the dev dependencies directly.

Please have a look into symfony skeleton project for example: https://github.com/symfony/website-skeleton/blob/4.0/composer.json#L29

Cloud edition "composer install" does not fetch the --dev dependencies of required packages.
That is the desired behavior of composer.
Every meta-package must resolve the dev dependencies directly.

Please have a look into symfony skeleton project for example: https://github.com/symfony/website-skeleton/blob/4.0/composer.json#L29
@cmuench
Copy link
Author

cmuench commented May 15, 2018

composer.lock needs to be updated.

@NadiyaS
Copy link
Contributor

NadiyaS commented Nov 29, 2018

Hi @cmuench ,
thanks for your report.
We won't add require-dev in cloud composer.json as during the deployment composer install runs without no-dev on all environments (inclusively production)

I'll close this PR.

Regards,
Nadiia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants