Composer.json for Magento 2.2 versions isn't in line with a normal Magento installation

[hostep]

Hi!

I don't know how important this is, but I'm reporting this for consistency's sake.

So, when I compare a composer.json file from Magento Open Source 2.1.x to 2.2.x when a project has been setup using composer create-project, I notice some changes being done to the composer.json file, which have not been applied to this project's composer.json file.
I know this project depends on those other Magento projects, but some of those composer.json changes only apply to the root project, so it doesn't matter if the required packages from this project have the new composer.json file, it's the root file which counts for some of the sections.

I'm talking about these sections:

• config
• autoload
• minimum-stability
• prefer-stable

Here is a diff between the composer.json file of a fresh Magento 2.1.12 and 2.2.5 project (minus the changes in the version, require or require-dev sections, since they are less relevant here):

--- magento21-test/composer.json	2018-07-20 18:31:52.000000000 +0200
+++ magento22-test/composer.json	2018-06-14 15:31:46.000000000 +0200
@@ -20,9 +20,6 @@
         "lusitanian/oauth": "~0.8.10",
         "sebastian/phpcpd": "2.0.4"
     },
-    "config": {
-        "use-include-path": true
-    },
     "autoload": {
         "psr-4": {
             "Magento\\Framework\\": "lib/internal/Magento/Framework/",
@@ -30,10 +27,17 @@
             "Magento\\": "app/code/Magento/"
         },
         "psr-0": {
-            "": "app/code/"
+            "": [
+                "app/code/"
+            ]
         },
         "files": [
             "app/etc/NonComposerComponentRegistration.php"
+        ],
+        "exclude-from-classmap": [
+            "**/dev/**",
+            "**/update/**",
+            "**/Test/**"
         ]
     },
     "autoload-dev": {
@@ -45,8 +49,7 @@
             "Magento\\TestFramework\\Utility\\": "dev/tests/static/framework/Magento/TestFramework/Utility/"
         }
     },
-    "minimum-stability": "alpha",
-    "prefer-stable": true,
+    "minimum-stability": "stable",
     "repositories": [
         {
             "type": "composer",

So the above changes are for Magento 2.2 projects.
But for 2.1 projects, there was also a slight change between 2.1.12 and 2.1.13 (also part of the diff above):

         "psr-0": {
-            "": "app/code/"
+            "": [
+                "app/code/"
+            ]
         },

Also there is no require-dev section, so people who want to run the default test suite of Magento have to add that manually, there is already a PR open here: #200

Again: I don't know how important all these changes are. The use-include-path probably not important, but setting the minimum-stability to stable is probably a good idea at least?

Some of these changes were done for performance improvements, see: magento/magento2@0b659d2

[YPyltiai]

Hi @hostep ,

I've created internal ticket MAGECLOUD-2523 to investigate this case.

Thanks,
Yevhenii

[YPyltiai]

Hi @hostep ,

This was resolved.

Thanks,
Yevhenii

[hostep]

Nice!

It's not fully resolved I believe, I still see some changes, even more in 2.3.0

But first Magento OS 2.2.6 vs Magento Cloud 2.2.6:

@@ -16,7 +16,6 @@
         },
         "psr-4": {
             "Magento\\": "app/code/Magento/",
-            "Magento\\Framework\\": "lib/internal/Magento/Framework/",
             "Magento\\Setup\\": "setup/src/Magento/Setup/"
         }
     },
@@ -30,19 +29,21 @@
         }
     },
     "extra": {
-        "magento-force": "override"
+        "magento-deploystrategy": "copy",
+        "magento-force": true
     },
     "license": [
         "OSL-3.0",
         "AFL-3.0"
     ],
-    "minimum-stability": "stable",
-    "repositories": [
-        {
+    "minimum-stability": "alpha",
+    "prefer-stable": true,
+    "repositories": {
+        "repo": {
             "type": "composer",
-            "url": "https://repo.magento.com/"
+            "url": "https://repo.magento.com"
         }
-    ],
+    },
     "type": "project",
     "version": "2.2.6"
 }

And then Magento OS 2.3.0 vs Magento Cloud 2.3.0:

@@ -16,7 +16,6 @@
         },
         "psr-4": {
             "Magento\\": "app/code/Magento/",
-            "Magento\\Framework\\": "lib/internal/Magento/Framework/",
             "Magento\\Setup\\": "setup/src/Magento/Setup/",
             "Zend\\Mvc\\Controller\\": "setup/src/Zend/Mvc/Controller/"
         }
@@ -30,24 +29,22 @@
             "Magento\\Tools\\Sanity\\": "dev/build/publication/sanity/Magento/Tools/Sanity/"
         }
     },
-    "config": {
-        "preferred-install": "dist",
-        "sort-packages": true
-    },
     "extra": {
-        "magento-force": "override"
+        "magento-deploystrategy": "copy",
+        "magento-force": true
     },
     "license": [
         "OSL-3.0",
         "AFL-3.0"
     ],
-    "minimum-stability": "stable",
-    "repositories": [
-        {
+    "minimum-stability": "alpha",
+    "prefer-stable": true,
+    "repositories": {
+        "repo": {
             "type": "composer",
-            "url": "https://repo.magento.com/"
+            "url": "https://repo.magento.com"
         }
-    ],
+    },
     "type": "project",
     "version": "2.3.0"
 }

If I'm wrong about this, let me know :)

[NadiyaS]

Hi @hostep,
thank you for your report,
[EDITED] sorry, did not update the page and missed your last comment.

So, about the changes which are left:

• lib/internal/Magento/Framework/ was removed from psr-4 as this directory does not exist for Magento package.
• data in extra is correct it should be differ than Magento has
• minimum-stability will left the same, please pay attention that we have prefer-stable enabled.

I will close this issue, but if you have other notices, please feel free to reopen it or create a new one.

Thank you,
Nadiia

[hostep]

Ok thanks for the explanation @NadiyaS !

What about the config section for Magento 2.3.0?
And the format of the repositories, array vs object? And the trailing forward slash in the url. (both 2.2 and 2.3)

All these aren't super important, but consistency over all the Magento repo's would be nice :)

[NadiyaS]

@hostep
yes, thank you for mentioning config section we definitely should add this too to 2.3