-
Notifications
You must be signed in to change notification settings - Fork 216
feat(proxy-metrics): document outbound policy routing metrics #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the documentation of our proxy metrics has not kept pace with all of the exciting telemetry that has been introduced since #1599 documented the state of our authorization policy metrics. this commit reworks the documentation to exhaustively document the families of metrics exported by the proxy. this commit does not introduce mention of the _inbound_ metrics that have been added, but does rename this section to "_Endpoint Metrics_" in order to be compatible with the future addition of `inbound_http_route_*`, `inbound_http_route_backend_*`, `inbound_grpc_route*`, and `inbound_grpc_route_backend_*` metrics. see: * linkerd/linkerd2-proxy#2377 * linkerd/linkerd2-proxy#2380 * linkerd/linkerd2-proxy#3086 * linkerd/linkerd2-proxy#3308 * linkerd/linkerd2-proxy#3334 Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for review: this should be copied over to the 2.19 docs, but i'd like to hold off until these proposed changes have been reviewed before i handle that.
|
to facilitate review, i'll attach a snapshot of the relevant outbound HTTP metrics scraped from a proxy as of |
|
marking this as 'ready for review', though as noted above these changes should be mirrored to the 2.19 documentation before merging. |
kflynn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @cratelyn, thank you! 🙂
this is done in d10a833. |
the documentation of our proxy metrics has not kept pace with all of the
exciting telemetry that has been introduced since
#1599 documented the state of our
authorization policy metrics.
this commit reworks the documentation to exhaustively document the
families of metrics exported by the proxy. this commit does not
introduce mention of the inbound metrics that have been added, but
does rename this section to "Endpoint Metrics" in order to be
compatible with the future addition of
inbound_http_route_*,inbound_http_route_backend_*,inbound_grpc_route*, andinbound_grpc_route_backend_*metrics.see:
Signed-off-by: katelyn martin [email protected]