Skip to content

Conversation

@olix0r
Copy link
Member

@olix0r olix0r commented Apr 6, 2023

It's not currently possible to know how many endpoints are in a balancer. This change adds an outbound_http_balancer_endpoints gauge that exposes the number of endpoints a balancer has by their current readiness status.

Note that in the concrete stack we do not currently differentiate between gRPC and HTTP backends, so all balancers are exposed under this single metric.

@olix0r olix0r requested a review from a team as a code owner April 6, 2023 21:41
It's not currently possible to know how many endpoints are in a
balancer. This change adds an `outbound_http_balancer_endpoints` gauge
that exposes the number of endpoints a balancer has by their current
readiness status.

Note that in the concrete stack we do not currently differentiate
between gRPC and HTTP backends, so all balancers are exposed under this
single metric.
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i complained about some unimportant stuff, but this looks great.

@hawkw hawkw merged commit d6f20a6 into main Apr 8, 2023
@hawkw hawkw deleted the ver/famtx branch April 8, 2023 00:13
hawkw added a commit to linkerd/linkerd2 that referenced this pull request Apr 8, 2023
This proxy release introduces a new `outbound_http_balancer_endpoints`
gauge metric which allows tracking the number of endpoints in a load
balancer by their readiness status. Additionally, it includes a fix for
outbound proxies not setting the `l5d-canonical-dst` header, which
results in missing inbound ServiceProfile route metrics (#10521).

---

* outbound: Report HTTP balancer endpoint gauges (linkerd/linkerd2-proxy#2380)
* outbound: add `l5d-dst-canonical` to requests with ServiceProfiles (linkerd/linkerd2-proxy#2383)
hawkw added a commit to linkerd/website that referenced this pull request Apr 10, 2023
This branch adds documentation for the new metrics added in
linkerd/linkerd2-proxy#2377 and linkerd/linkerd2-proxy#2380.
hawkw added a commit to linkerd/website that referenced this pull request Apr 10, 2023
This branch adds documentation for the new metrics added in
linkerd/linkerd2-proxy#2377 and linkerd/linkerd2-proxy#2380.
cratelyn added a commit to linkerd/website that referenced this pull request Nov 14, 2025
the documentation of our proxy metrics has not kept pace with all of the
exciting telemetry that has been introduced since
#1599 documented the state of our
authorization policy metrics.

this commit reworks the documentation to exhaustively document the
families of metrics exported by the proxy. this commit does not
introduce mention of the _inbound_ metrics that have been added, but
does rename this section to "_Endpoint Metrics_" in order to be
compatible with the future addition of `inbound_http_route_*`,
`inbound_http_route_backend_*`, `inbound_grpc_route*`, and
`inbound_grpc_route_backend_*` metrics.

see:
* linkerd/linkerd2-proxy#2377
* linkerd/linkerd2-proxy#2380
* linkerd/linkerd2-proxy#3086
* linkerd/linkerd2-proxy#3308
* linkerd/linkerd2-proxy#3334

Signed-off-by: katelyn martin <[email protected]>
kflynn pushed a commit to linkerd/website that referenced this pull request Nov 20, 2025
* feat(proxy-metrics): document outbound policy routing metrics

the documentation of our proxy metrics has not kept pace with all of the
exciting telemetry that has been introduced since
#1599 documented the state of our
authorization policy metrics.

this commit reworks the documentation to exhaustively document the
families of metrics exported by the proxy. this commit does not
introduce mention of the _inbound_ metrics that have been added, but
does rename this section to "_Endpoint Metrics_" in order to be
compatible with the future addition of `inbound_http_route_*`,
`inbound_http_route_backend_*`, `inbound_grpc_route*`, and
`inbound_grpc_route_backend_*` metrics.

see:
* linkerd/linkerd2-proxy#2377
* linkerd/linkerd2-proxy#2380
* linkerd/linkerd2-proxy#3086
* linkerd/linkerd2-proxy#3308
* linkerd/linkerd2-proxy#3334

Signed-off-by: katelyn martin <[email protected]>

* chore(markdownlint): allow duplicate "labels" headers

Signed-off-by: katelyn martin <[email protected]>

---------

Signed-off-by: katelyn martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants