Skip to content

fix(destination)!: replace ip_port_subscribers with workload_subscribers #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix(destination)!: replace ip_port_subscribers with workload_subscribers #14612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f9351
fix(destination): drop ip and port metric labels
olix0r Oct 12, 2025
6f919c8
rename metric to workload_subscribers
olix0r Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions controller/api/destination/watcher/workload_watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"fmt"
"net"
"strconv"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -61,7 +60,7 @@ type (
}
)

var ipPortVecs = newMetricsVecs("ip_port", []string{"ip", "port"})
var workloadVecs = newMetricsVecs("workload", []string{})

func NewWorkloadWatcher(k8sAPI *k8s.API, metadataAPI *k8s.MetadataAPI, log *logging.Entry, enableEndpointSlices bool, defaultOpaquePorts map[uint32]struct{}) (*WorkloadWatcher, error) {
ww := &WorkloadWatcher{
Expand Down Expand Up @@ -455,10 +454,8 @@ func (ww *WorkloadWatcher) getOrNewWorkloadPublisher(service *ServiceID, hostnam
ipPort := IPPort{ip, port}
wp, ok := ww.publishers[ipPort]
if !ok {
metrics, err := ipPortVecs.newMetrics(prometheus.Labels{
"ip": ip,
"port": strconv.FormatUint(uint64(port), 10),
})
// Omit high-cardinality IP:port labels.
metrics, err := workloadVecs.newMetrics(prometheus.Labels{})
if err != nil {
return nil, err
}
Expand Down