fix(destination)!: replace ip_port_subscribers with workload_subscribers #14612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination control's ip_port_subscriber and ip_port_updates metrics are potentailly exposed for every IP that is discovered. This is high cardinality and puts undo pressure on the metrics infrastructure. This change drops these labels, so that there is a single ip_port_subscriber and ip_port_updates timeseries.
olix0r
changed the title
adleong
reviewed
Oct 13, 2025
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
since we're changing the labels anyway, should we also change the metric name? "ip_port" probably doesn't make sense without ip and port labels.
olix0r
changed the title
adleong
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination control's ip_port_subscriber and ip_port_updates metrics are potentailly exposed for every IP that is discovered. This is high cardinality and puts undo pressure on the metrics infrastructure.
This change drops these labels, so that there is a single ip_port_subscriber and ip_port_updates timeseries.