Skip to content

Conversation

@habara-k
Copy link
Contributor

@habara-k habara-k commented Oct 31, 2024

This resolves #464 with PR line/line-openapi#70

Changes

We are customizing SDK code generation to generate code that directly passes arguments to functions, instead of using a request body struct for the API.
As a result, we are unable to use the "omitempty" tag to ignore fields with empty strings.

To address this issue, we will modify the code to exclude optional string fields from url.Values when they are empty.

@habara-k habara-k requested a review from mokuzon October 31, 2024 02:57
@habara-k habara-k marked this pull request as draft October 31, 2024 03:10
@habara-k habara-k marked this pull request as ready for review October 31, 2024 03:20
@mokuzon
Copy link
Contributor

mokuzon commented Oct 31, 2024

@habara-k Could you also add the auto-generated code to the PR in a separate commit?
(I understand it is auto-generated during the release process, but I would like to see the differences now)

@habara-k habara-k force-pushed the ignore-empty-string-for-optional-args branch from 975d496 to 12af99a Compare October 31, 2024 04:14
@habara-k habara-k force-pushed the ignore-empty-string-for-optional-args branch from 12af99a to 7a72353 Compare October 31, 2024 04:14
@habara-k habara-k requested review from mokuzon and removed request for mokuzon October 31, 2024 05:23
@habara-k habara-k merged commit d151fe3 into line:master Oct 31, 2024
Yang-33 pushed a commit that referenced this pull request Nov 28, 2024
This PR adds tests for these changes to correctly ignore empty values.

- #496
- #497
- #498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How can I call IssueStatelessChannelToken in the case of without client_assertion and client_assertion_type

2 participants