Fix bug: integer cannot be null #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokuzon
reviewed
Oct 30, 2024
| return true; | ||
| } | ||
|
|
||
| private boolean hasMinimumValueGreaterThanZero(String minValue) { |
Contributor
There was a problem hiding this comment.
For the content of this method, isGreaterThanZero is more suitable.
mokuzon
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This resolve #466.
Details
By using the
omitemptytag on an int field, you can ignore the field during JSON serialization when its value is set to 0.This is necessary for endpoints with request bodies that have optional int fields, allowing the request to be made without specifying that field.
Without the omitempty tag, the request would treat the field as if 0 were explicitly specified.
However, this setting should be limited to fields where specifying a 0 value is not intended. Otherwise, it would prevent the ability to explicitly set a 0 value for those fields.