Add IBelongToARepository #806
Conversation
|
Do we need to implement the interface for every derived types once the base ones expose it? Note: |
| /// <param name="canonicalName">The canonical name.</param> | ||
| /// <param name="targetIdentifier">The target identifier.</param> | ||
| protected Reference(string canonicalName, string targetIdentifier) | ||
| protected Reference(IRepository repo, string canonicalName, string targetIdentifier) |
There was a problem hiding this comment.
So it does, though this ctor was never meant for public consumption. I've marked this one as [Obsolete] in favor of an internal one with the new signature.
On closer inspection, the namespace is not actually unused...R# got confused. |
|
Fixed and added new meta test. Failure looks like this:
|
dahlbyk
force-pushed
the
IBelong
branch
2 times, most recently
from
0549b3a to
ee0d0b7
Compare
|
So my first pass at this was basically terrible. Trying again, with some sanity check tests for good measure. |
| /// </summary> | ||
| IRepository Repository { get; } | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's take a moment of silence to reflect on all the good things POSIX has brought us 
|
I don't hear anyone strongly opposing to this. Let's move it in. Could you please rebase this PR? |
Done |
|
It's a go! 👍 |
As discussed in #574 and #665, here's an interface that allows access to an instance's corresponding
IRepositoryfor certain (non-standard) usage patterns.TODO: