Skip to content

Introduce internal ICommittish #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dahlbyk
Copy link
Member

@dahlbyk dahlbyk commented Apr 9, 2014

As originally proposed in #667, this introduces an internal interface to let stuff that can identify a commit own how to do so (rather than having that logic live in RepositoryExtensions).

@nulltoken doesn't like the name ICommittish, and I agree. His last comment:

Considering this and the fact that a Tag may also point to something else than a Commit, about about renaming it to ITargetObjectIdAccessor and making it return an ObjectId (or null when dealing with an unborn branch for instance)?

@nulltoken
Copy link
Member

Can we close this as #806 has been merged?

@dahlbyk
Copy link
Member Author

dahlbyk commented Nov 23, 2014

I don't believe they are related?

@nulltoken
Copy link
Member

Just... ignore me 😊

@Therzok
Copy link
Member

Therzok commented Nov 23, 2014

ignores @nulltoken
continues pushing to master

@bording bording closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants