Skip to content

Check that version number is corectly embedded in the binary #7092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 3, 2025
Merged

Check that version number is corectly embedded in the binary #7092

merged 11 commits into from
May 3, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 2, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Add validation to the build step that the version number is correctly embedded in the binary

How was this change tested?

$ make build-jaeger
echo "building binary for $(go env GOOS)-$(go env GOARCH)"; CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/jaeger/jaeger-darwin-arm64   -ldflags "-X   github.com/jaegertracing/jaeger/pkg/version.commitSHA=687207be86edb688436f8ef6c4383968a0ec1855 -X   github.com/jaegertracing/jaeger/pkg/version.latestVersion=v2.5.0 -X   github.com/jaegertracing/jaeger/pkg/version.date=2025-05-02T18:47:48Z" ./cmd/jaeger
building binary for darwin-arm64
❌ ERROR: version mismatch: want=v2.5.0, have=
make: *** [build-jaeger] Error 1

@yurishkuro yurishkuro requested a review from a team as a code owner May 2, 2025 18:48
@yurishkuro yurishkuro requested a review from albertteoh May 2, 2025 18:48
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 2, 2025
@yurishkuro
fix
65cbc7a 
Signed-off-by: Yuri Shkuro <[email protected]>
@codecov Codecov
Copy link

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (9d1e94c) to head (86b8e27).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7092      +/-   ##
==========================================
- Coverage   96.14%   96.11%   -0.03%     
==========================================
  Files         358      358              
  Lines       21584    21584              
==========================================
- Hits        20752    20746       -6     
- Misses        627      631       +4     
- Partials      205      207       +2
Flag Coverage Δ
badger_v1 9.91% <ø> (ø)
badger_v2 2.05% <ø> (ø)
cassandra-4.x-v1-manual 14.91% <ø> (ø)
cassandra-4.x-v2-auto 2.04% <ø> (ø)
cassandra-4.x-v2-manual 2.04% <ø> (ø)
cassandra-5.x-v1-manual 14.91% <ø> (ø)
cassandra-5.x-v2-auto 2.04% <ø> (ø)
cassandra-5.x-v2-manual 2.04% <ø> (ø)
elasticsearch-6.x-v1 20.17% <ø> (ø)
elasticsearch-7.x-v1 20.25% <ø> (ø)
elasticsearch-8.x-v1 20.43% <ø> (ø)
elasticsearch-8.x-v2 2.05% <ø> (ø)
grpc_v1 11.46% <ø> (ø)
grpc_v2 2.05% <ø> (ø)
kafka-3.x-v1 10.19% <ø> (ø)
kafka-3.x-v2 2.05% <ø> (ø)
memory_v2 2.05% <ø> (ø)
opensearch-1.x-v1 20.30% <ø> (ø)
opensearch-2.x-v1 20.30% <ø> (ø)
opensearch-2.x-v2 2.05% <ø> (ø)
query 2.05% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests 94.92% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro added 8 commits May 2, 2025 15:22
@yurishkuro
fix
a268a1c 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
73b8757 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
d637d41 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
46aaf5a 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
2cd4698 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
a4b76ab 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
c1cddf6 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
168e028 
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
yurishkuro commented May 2, 2025
View reviewed changes
@yurishkuro
fix
86b8e27 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge May 2, 2025 21:42
@yurishkuro yurishkuro added this pull request to the merge queue May 3, 2025
Merged via the queue into jaegertracing:main with commit e3c5d9f May 3, 2025
57 checks passed
@yurishkuro yurishkuro deleted the check-version branch May 3, 2025 12:51
@yurishkuro yurishkuro mentioned this pull request May 4, 2025
Merged
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@yurishkuro @amol-verma-allen
Check that version number is corectly embedded in the binary (jaegert…
1a97cd2 
…racing#7092)

## Which problem is this PR solving?
- Resolves jaegertracing#7090

## Description of the changes
- Add validation to the build step that the version number is correctly
embedded in the binary

## How was this change tested?
- When reverting the fix done in jaegertracing#6990 the build fails:
```
$ make build-jaeger
echo "building binary for $(go env GOOS)-$(go env GOARCH)"; CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/jaeger/jaeger-darwin-arm64   -ldflags "-X   github.com/jaegertracing/jaeger/pkg/version.commitSHA=687207be86edb688436f8ef6c4383968a0ec1855 -X   github.com/jaegertracing/jaeger/pkg/version.latestVersion=v2.5.0 -X   github.com/jaegertracing/jaeger/pkg/version.date=2025-05-02T18:47:48Z" ./cmd/jaeger
building binary for darwin-arm64
❌ ERROR: version mismatch: want=v2.5.0, have=
make: *** [build-jaeger] Error 1
```

---------

Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@yurishkuro @amol-verma-allen
Check that version number is corectly embedded in the binary (jaegert…
942e738 
…racing#7092)

## Which problem is this PR solving?
- Resolves jaegertracing#7090

## Description of the changes
- Add validation to the build step that the version number is correctly
embedded in the binary

## How was this change tested?
- When reverting the fix done in jaegertracing#6990 the build fails:
```
$ make build-jaeger
echo "building binary for $(go env GOOS)-$(go env GOARCH)"; CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/jaeger/jaeger-darwin-arm64   -ldflags "-X   github.com/jaegertracing/jaeger/pkg/version.commitSHA=687207be86edb688436f8ef6c4383968a0ec1855 -X   github.com/jaegertracing/jaeger/pkg/version.latestVersion=v2.5.0 -X   github.com/jaegertracing/jaeger/pkg/version.date=2025-05-02T18:47:48Z" ./cmd/jaeger
building binary for darwin-arm64
❌ ERROR: version mismatch: want=v2.5.0, have=
make: *** [build-jaeger] Error 1
```

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahadzaryab1 mahadzaryab1 mahadzaryab1 approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: UI no longer shows Jaeger's build info
2 participants
@yurishkuro @mahadzaryab1