[bug] Fix the version module path in ldflags

[developer-guy]

I noticed that you have changed the version module path so we have to update the path in the ldflags too:

jaeger/CHANGELOG.md

Line 86 in 06840ac

* Move pkg/version to internal/version ([@danish9039](https://github.com/danish9039) in [#6913](https://github.com/jaegertracing/jaeger/pull/6913))

[yurishkuro]

Thanks. Is there a way to have this code fail on the wrong paths?

[developer-guy]

I'm not sure how we could test this sorry :(

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (06840ac) to head (cadb892).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6990   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         346      346           
  Lines       20429    20429           
=======================================
  Hits        19611    19611           
  Misses        616      616           
  Partials      202      202           

Flag	Coverage Δ
badger_v1	10.53% <ø> (ø)
badger_v2	2.18% <ø> (ø)
cassandra-4.x-v1-manual	15.84% <ø> (ø)
cassandra-4.x-v2-auto	2.17% <ø> (ø)
cassandra-4.x-v2-manual	2.17% <ø> (ø)
cassandra-5.x-v1-manual	15.84% <ø> (ø)
cassandra-5.x-v2-auto	2.17% <ø> (ø)
cassandra-5.x-v2-manual	2.17% <ø> (ø)
elasticsearch-6.x-v1	20.76% <ø> (ø)
elasticsearch-7.x-v1	20.84% <ø> (ø)
elasticsearch-8.x-v1	21.02% <ø> (ø)
elasticsearch-8.x-v2	2.18% <ø> (ø)
grpc_v1	11.61% <ø> (ø)
grpc_v2	8.47% <ø> (ø)
kafka-3.x-v1	10.82% <ø> (ø)
kafka-3.x-v2	2.18% <ø> (ø)
memory_v2	2.18% <ø> (ø)
opensearch-1.x-v1	20.89% <ø> (ø)
opensearch-2.x-v1	20.89% <ø> (ø)
opensearch-2.x-v2	2.18% <ø> (ø)
tailsampling-processor	0.59% <ø> (ø)
unittests	94.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[developer-guy]

we could write another script where we could test the build time injection like the following:

#!/bin/bash
set -e

go build -ldflags="-X 'main.version=$1'" -o app main.go
output=$(./app)

if [[ "$output" == "Version: $1" ]]; then
    echo "✅ PASS: Injected version correctly: $output"
else
    echo "❌ FAIL: Unexpected version: $output"
    exit 1
fi

then we could run it as another step in the release workflows.

[yurishkuro]

we could write another script where we could test the build time injection like the following:

would you like to add this in another PR? It doesn't need to be a separate script, just an extra check in the build process, perhaps in build-jaeger in scripts/makefiles/BuildBinaries.mk