Remove package pkg/netutils #6955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipiland2612
force-pushed
the
6869-use-internal-package
branch
2 times, most recently
from
6f3eafc to
93293a4
Compare
Signed-off-by: pipiland <[email protected]>
pipiland2612
force-pushed
the
6869-use-internal-package
branch
from
93293a4 to
ef44c08
Compare
|
@yurishkuro This change is ready. I would love to hear your feedback! |
yurishkuro
approved these changes
Apr 1, 2025
mahadzaryab1
added
the
changelog:refactoring
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6955 +/- ##
==========================================
- Coverage 96.22% 96.18% -0.05%
==========================================
Files 344 343 -1
Lines 20253 20245 -8
==========================================
- Hits 19488 19472 -16
- Misses 577 583 +6
- Partials 188 190 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - Remove package pkg/netutils by - removing unused function `FixLocalhost` - moving function GetPort as private util function `getPortForAddr` within package `cmd/query/app` - the only place where this function is used ## How was this change tested? - running existing tests in the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 ## Description of the changes - Remove package pkg/netutils by - removing unused function `FixLocalhost` - moving function GetPort as private util function `getPortForAddr` within package `cmd/query/app` - the only place where this function is used ## How was this change tested? - running existing tests in the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
FixLocalhostgetPortForAddrwithin packagecmd/query/app- the only place where this function is usedHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test