Remove package pkg/netutils (jaegertracing#6955)

## Which problem is this PR solving?
- part of jaegertracing#6869

## Description of the changes

- Remove package pkg/netutils by
   - removing unused function `FixLocalhost`
- moving function GetPort as private util function `getPortForAddr`
within package `cmd/query/app` - the only place where this function is
used

## How was this change tested?

- running existing tests in the project

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: pipiland <[email protected]>
Signed-off-by: amol-verma-allen <[email protected]>

Author: pipiland2612

cmd/query/app/server.go

@@ -34,7 +34,6 @@ import (
 	"github.com/jaegertracing/jaeger/internal/recoveryhandler"
 	"github.com/jaegertracing/jaeger/internal/telemetry"
 	"github.com/jaegertracing/jaeger/internal/tenancy"
-	"github.com/jaegertracing/jaeger/pkg/netutils"
 )
 
 // Server runs HTTP, Mux and a grpc server
@@ -270,12 +269,12 @@ func (s *Server) Start(ctx context.Context) error {
 	}
 
 	var httpPort int
-	if port, err := netutils.GetPort(s.httpConn.Addr()); err == nil {
+	if port, err := getPortForAddr(s.httpConn.Addr()); err == nil {
 		httpPort = port
 	}
 
 	var grpcPort int
-	if port, err := netutils.GetPort(s.grpcConn.Addr()); err == nil {
+	if port, err := getPortForAddr(s.grpcConn.Addr()); err == nil {
 		grpcPort = port
 	}
 

cmd/query/app/util.go

@@ -4,6 +4,9 @@
 package app
 
 import (
+	"net"
+	"strconv"
+
 	"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
 )
 
@@ -19,3 +22,18 @@ func getUniqueOperationNames(operations []spanstore.Operation) []string {
 	}
 	return operationNames
 }
+
+// getPortForAddr returns the port of an endpoint address.
+func getPortForAddr(addr net.Addr) (int, error) {
+	_, port, err := net.SplitHostPort(addr.String())
+	if err != nil {
+		return -1, err
+	}
+
+	parsedPort, err := strconv.Atoi(port)
+	if err != nil {
+		return -1, err
+	}
+
+	return parsedPort, nil
+}

cmd/query/app/util_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 
 	"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
 )
@@ -25,3 +26,51 @@ func Test_getUniqueOperationNames(t *testing.T) {
 	assert.Len(t, names, 2)
 	assert.ElementsMatch(t, expNames, names)
 }
+
+func Test_getPort(t *testing.T) {
+	cases := []struct {
+		address       testAddr
+		expected      int
+		expectedError string
+	}{
+		{
+			address: testAddr{
+				Address: "localhost:0",
+			},
+			expected: 0,
+		},
+		{
+			address: testAddr{
+				Address: "localhost",
+			},
+			expectedError: "address localhost: missing port in address",
+		},
+		{
+			address: testAddr{
+				Address: "localhost:port",
+			},
+			expectedError: "strconv.Atoi: parsing \"port\": invalid syntax",
+		},
+	}
+	for _, c := range cases {
+		port, err := getPortForAddr(&c.address)
+		if c.expectedError != "" {
+			require.EqualError(t, err, c.expectedError)
+		} else {
+			assert.Equal(t, c.expected, port)
+		}
+	}
+}
+
+type testAddr struct {
+	Address string
+}
+
+// Implement net.Addr methods
+func (*testAddr) Network() string {
+	return "tcp"
+}
+
+func (tA *testAddr) String() string {
+	return tA.Address
+}