Skip to content

Move pkg/gzipfs to internal/gzipfs #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/query/app/ui/assets.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"go.uber.org/zap"

"github.com/jaegertracing/jaeger/pkg/gzipfs"
"github.com/jaegertracing/jaeger/internal/gzipfs"
"github.com/jaegertracing/jaeger/pkg/httpfs"
)

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion pkg/gzipfs/gzip_test.go → internal/gzipfs/gzip_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestFS(t *testing.T) {
// To provide coverage of the error from io.ReadAll function, we use a file
// that is a copy of proper gzipped file testdata/foobaz.gz but truncated
// to 36 bytes with:
// perl -e "truncate 'pkg/gzipfs/testdata/foobaz_truncated.gz', 36"
// perl -e "truncate 'internal/gzipfs/testdata/foobaz_truncated.gz', 36"
// This allows gzip.NewReader() to succeed because the file has a proper gz
// header, but subsequent read fails with unexpected EOF.
name: "compressed but truncated file accessed without gz extension",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading