[refactor] Return chunk of traces from remote storage api v2 #6830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6830 +/- ##
==========================================
+ Coverage 96.05% 96.07% +0.02%
==========================================
Files 365 366 +1
Lines 20720 20750 +30
==========================================
+ Hits 19902 19935 +33
+ Misses 624 622 -2
+ Partials 194 193 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Mar 9, 2025
| @@ -129,6 +129,12 @@ message FindTraceIDsResponse { | |||
| repeated FoundTraceID trace_ids = 1; | |||
| } | |||
|
|
|||
| // TracesChunk is a chunk of traces returned by the storage backend. | |||
| // Each TracesData object contains spans belonging to a single trace. | |||
There was a problem hiding this comment.
Suggested change
| // Each TracesData object contains spans belonging to a single trace. | |
| // All spans in a single TracesData object MUST belong to the same trace. | |
| // Spans from a single large trace MAY be split across multiple chunks, | |
| // but those chunks MUST be consecutive. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Mar 9, 2025
| @@ -129,6 +129,14 @@ message FindTraceIDsResponse { | |||
| repeated FoundTraceID trace_ids = 1; | |||
| } | |||
|
|
|||
| // Chunking requirements: | |||
| // - A single chunk MUST NOT contain spans from multiple traces. | |||
There was a problem hiding this comment.
the use of the word "chunk" is misleading here. Since the type is called xxChunk one might interpret that the whole chunk (multiple v1.TracesData entries) must be for the same trace, which is not the case.
yurishkuro
reviewed
Mar 9, 2025
yurishkuro
reviewed
Mar 9, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
added
changelog:bugfix-or-minor-feature
changelog:exprimental
yurishkuro
approved these changes
Mar 9, 2025
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6830) ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR addresses jaegertracing#6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace from `GetTraces` and `FindTraces` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6830) ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR addresses jaegertracing#6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace from `GetTraces` and `FindTraces` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
GetServicesCall in GRPC reader for remote storage api v2 #6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace fromGetTracesandFindTracesHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test