[grpc][v2] Implement GetServices Call in GRPC reader for remote storage api v2
#6829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
GetTraces Call to GRPC client for remote storage api v2GetTraces Call in GRPC client for remote storage api v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6829 +/- ##
==========================================
- Coverage 96.05% 96.05% -0.01%
==========================================
Files 365 367 +2
Lines 20720 20768 +48
==========================================
+ Hits 19902 19948 +46
- Misses 624 626 +2
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Mar 9, 2025
yurishkuro
reviewed
Mar 9, 2025
yurishkuro
reviewed
Mar 9, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Mar 9, 2025
| func TestTraceReader_GetOperations(t *testing.T) { | ||
| tr := &TraceReader{} | ||
|
|
||
| require.Panics(t, func() { |
There was a problem hiding this comment.
I think the panic will be from nil ptr dereference rather than from "not implemented"
yurishkuro
reviewed
Mar 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 9, 2025
## Which problem is this PR solving? - Towards #6789 ## Description of the changes - This PR addresses #6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace from `GetTraces` and `FindTraces` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
GetTraces Call in GRPC client for remote storage api v2GetServices Call in GRPC client for remote storage api v2
yurishkuro
approved these changes
Mar 10, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
GetServices Call in GRPC client for remote storage api v2GetServices Call in GRPC reader for remote storage api v2
yurishkuro
approved these changes
Mar 11, 2025
mahadzaryab1
added
changelog:exprimental
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6830) ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR addresses jaegertracing#6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace from `GetTraces` and `FindTraces` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…rage api v2 (jaegertracing#6829) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR implements a `TraceReader` for the remote storage API v2 along with `GetServices` call. ## How was this change tested? - Added a unit test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…racing#6830) ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR addresses jaegertracing#6829 (comment) and changes the remote storage api v2 to return a chunk of traces instead of a single trace from `GetTraces` and `FindTraces` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…rage api v2 (jaegertracing#6829) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6789 ## Description of the changes - This PR implements a `TraceReader` for the remote storage API v2 along with `GetServices` call. ## How was this change tested? - Added a unit test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
TraceReaderfor the remote storage API v2 along withGetServicescall.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test